[Kolab-devel] [PATCH] better modes

[Gunnar Wrobel]

Quoting "Jeroen van Meeuwen (Kolab Systems)" <vanmeeuwen at kolabsys.com>:

> Attached is a patch to apply to kolabd/kolabd/Makefile.am.
>
> 1) Installing a file chmod 444 prevents build processes from changing any
> ownership attributes and modes
>
> 2) If you can read it, you can execute it.

Thanks! Commited to CVS.

Concerning kolab.globals I'm not 100% certain everyone agrees to the  
change. It has been added by Richard Bos not too long ago (which is  
why I added him on cc). In principle you should never really change  
kolab.globals and mode 444 was intended to indicate that. The file is  
specific to your distribution and there are usually no reasons to  
modify it.

The file lies in /etc though and it also has a few variable (e.g.  
"log_level" or "debug") that can/should be touched by the sysadmin  
under certain circumstances. So I think mode 644 makes more sense for  
the file. It is probably better to add a header to that files that  
explicitely states that it is not intended for modification.

A general remark: Patches for the Kolab server should better go into a  
separate issue on issues.kolab.org. The mailing list gets a  
notification automatically and chances that your patch gets forgotten  
are significantly lower.

Cheers,

Gunnar


>
> --
> Jeroen van Meeuwen
> Senior Engineer, Kolab Systems AG
>
> e: vanmeeuwen at kolabsys.com
> t: +316 42 801 403
> w: http://www.kolabsys.com
>
> pgp: 9342 BF08
>



-- 
____ http://www.pardus.de _________________ http://gunnarwrobel.de _

E-mail : p at rdus.de                                 Dr. Gunnar Wrobel
Tel.   : +49 700 6245 0000                         Bundesstrasse 29
Fax    : +49 721 1513 52322                        D-20146 Hamburg
--------------------------------------------------------------------
    >> Mail at ease - Rent a kolab groupware server at p at rdus <<
--------------------------------------------------------------------

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digitale PGP-Unterschrift
URL: <http://lists.kolab.org/pipermail/devel/attachments/20100603/e6385d1d/attachment.sig>