[Kolab-devel] [PATCH] better modes

[Thomas Arendsen Hein]

* Gunnar Wrobel <wrobel at pardus.de> [20100603 15:50]:
> Quoting "Jeroen van Meeuwen (Kolab Systems)" <vanmeeuwen at kolabsys.com>:
>
>> Attached is a patch to apply to kolabd/kolabd/Makefile.am.
>>
>> 1) Installing a file chmod 444 prevents build processes from changing any
>> ownership attributes and modes
>>
>> 2) If you can read it, you can execute it.
>
> Thanks! Commited to CVS.
>
> Concerning kolab.globals I'm not 100% certain everyone agrees to the  
> change. It has been added by Richard Bos not too long ago (which is why I 
> added him on cc). In principle you should never really change  
> kolab.globals and mode 444 was intended to indicate that. The file is  
> specific to your distribution and there are usually no reasons to modify 
> it.

And I am still unsure about that.

I do not understand "444 prevents build processes from changing any
ownership attributes and modes". What exactly does not work?

> The file lies in /etc though and it also has a few variable (e.g.  
> "log_level" or "debug") that can/should be touched by the sysadmin under 
> certain circumstances. So I think mode 644 makes more sense for the file. 

No, you should simply copy those lines to kolab.conf and modify them
to your needs.

> It is probably better to add a header to that files that explicitely 
> states that it is not intended for modification.

That's probably good, too :)

> A general remark: Patches for the Kolab server should better go into a  
> separate issue on issues.kolab.org. The mailing list gets a notification 
> automatically and chances that your patch gets forgotten are 
> significantly lower.

I did not forget this patch, I just saw more need for discussion
than available time. But yes, using the issues.kolab.org might be
good for tracking the progress.

Regarding "2) If you can read it, you can execute it.":
Sure, but with this you can indicate that this should not be
executed by anyone. But I have no problem with this change, these
scripts are probably not important enough to discuss them.

Regards,
Thomas

-- 
thomas at intevation.de - http://intevation.de/~thomas/ - OpenPGP key: 0x5816791A
Intevation GmbH, Neuer Graben 17, 49074 Osnabrueck - AG Osnabrueck, HR B 18998
Geschaeftsfuehrer: Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.kolab.org/pipermail/devel/attachments/20100608/be18686a/attachment.sig>