changes in addressbook

[Mihai Badici]

I started a new test build for roundcube with kolab plugins just to 
refresh my existing template. I used the current master branch for 
roundcube and the same for kolab repos.

I encountered two new issues till now, I will wrote 2 mails to keep them 
distinct.


In kolab_addressbook, I had this fatal error:

Declaration of kolab_contacts::set_search_set($filter) must be 
compatible with rcube_addressbook::set_search_set($filter): void

and

Declaration of kolab_contacts::reset() must be compatible with 
rcube_addressbook::reset()


It looks like there is a recent change in roundcube addressbook which 
declare set_search_set and reset functions as void. This is not 
reflected in kolab_contacts. I fixed it adding : void to kolab_contacts 
definitions.

Honestly I don't see any big advantage to declare them void but maybe 
the explicit type will be enforced in php or can be other reasons for that.




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kolab.org/pipermail/users/attachments/20240205/67f63853/attachment.htm>