<!DOCTYPE html>
<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
</head>
<body>
<p>I started a new test build for roundcube with kolab plugins just
to refresh my existing template. I used the current master branch
for roundcube and the same for kolab repos.</p>
<p>I encountered two new issues till now, I will wrote 2 mails to
keep them distinct.</p>
<p><br>
</p>
<p>In kolab_addressbook, I had this fatal error:</p>
<p><span style="font-family:monospace"><span
style="color:#000000;background-color:#ffffff;">Declaration of
kolab_contacts::set_search_set($filter) must be compatible
with rcube_addressbook::set_search_set($filter): void <br>
</span></span></p>
<p><span style="font-family:monospace"><span
style="color:#000000;background-color:#ffffff;">and <br>
</span></span></p>
<p><span style="font-family:monospace"><span
style="color:#000000;background-color:#ffffff;">Declaration of
kolab_contacts::reset() must be compatible with
rcube_addressbook::reset()</span></span></p>
<p><span style="font-family:monospace"><span
style="color:#000000;background-color:#ffffff;"><br>
</span></span></p>
<p><span style="color:#000000;background-color:#ffffff;">It looks
like there is a recent change in roundcube addressbook which
declare set_search_set and reset functions as void. This is not
reflected in kolab_contacts. I fixed it adding : void to
kolab_contacts definitions.<br>
</span></p>
<p><span style="color:#000000;background-color:#ffffff;">Honestly I
don't see any big advantage to declare them void but maybe the
explicit type will be enforced in php or can be other reasons
for that.<br>
</span><span style="font-family:monospace"><span
style="color:#000000;background-color:#ffffff;"></span></span></p>
<p><br>
</p>
<p><br>
</p>
<p><br>
</p>
<p><br>
</p>
</body>
</html>