[Kolab-devel] Possible typo in roundcube rcmail.php

[Thomas Brüderli]

Thomas Z. wrote:
> /usr/share/roundcubemail/program/include/rcmail.php
> about line 240
> 
>         if (!$contacts) {
>             // there's no default, just return
>             if ($default) {
>                 return null;
>             }
> 
> 
> should be (assuming the comment is correct and the error message I get
> logged is false)
> 
>         if (!$contacts) {
>             // there's no default, just return
>             if (!$default) { <------
>                 return null;
>             }

Nope, the code is correct. $default being true means that the default
address book was requested. If not exists, we can exit here.

~Thomas