[Kolab-devel] wilde: server/imapd/patches/cyrus-imapd-2.3.16 cyrus-imapd-cross-domain-acls.patch, NONE, 1.1

[Gunnar Wrobel]

Quoting Richard Bos <ml at radoeka.nl>:

> Op maandag 15 februari 2010 12:19:23 schreef Sascha Wilde:
>> Richard Bos <ml at radoeka.nl> writes:
>> > Op maandag 08 februari 2010 18:19:42 schreef cvs at kolab.org:
>> >> Update of /kolabrepository/server/imapd/patches/cyrus-imapd-2.3.16
>> >> In directory doto:/tmp/cvs-serv24076/imapd/patches/cyrus-imapd-2.3.16
>> >>
>> >> Added Files:
>> >>         cyrus-imapd-cross-domain-acls.patch
>> >> Log Message:
>> >> Added Bernhard Herzog's cross domain acl patch (see kolab/issue1141).
>> >
>> > Is it possible to rename this patch (cyrus-imapd-cross-domain-acls.patch)
>> > to: KOLAB_cyrus-imapd-cross-domain-acls.patch
>> >
>> > Similar to the other patches in:
>> > http://kolab.org/cgi-bin/viewcvs-kolab.cgi/server/imapd/patches/cyrus-
>> > imapd-2.3.16/
>>
>> Yes, I agree that's a good idea.  Feel free to rename it.  Please make
>> sure that the patch still applies after the change.
>
> The latter has nothing to do with a name change.  Someone that packages cyrus
> for openpkg would be a better candidate to rename.  He can do the  
> renaming and
> the change in the spec file at the same time.   That will take care that the
> patch continues to apply...

Done. Still builds fine but I did not yet check the functionality.

While I personally think the starting "KOLAB" tag is not that  
important it is nice to have as an indicator where the patch comes  
from. The version tag in the file name has technical reasons though  
and we should try to keep it. It is useful within the spec files and  
helps when migrating the patch queue to a newer version.

@sascha: There is also a "series" file in the  
"patches/cyrus-imapd-2.3.16" directory that indicates the patch order.  
I know that we have the information in the spec file, too. But the  
series file helps with quickly updating the patch queue when a new  
cyrus imap server version arrives. The "imapd/patches/Makefile"  
contains some magic which automates the process using the mercurial  
patch queue management.

Cheers,

Gunnar

>
> --
> Richard
>
> _______________________________________________
> Kolab-devel mailing list
> Kolab-devel at kolab.org
> https://kolab.org/mailman/listinfo/kolab-devel
>



-- 
______ http://kdab.com _______________ http://kolab-konsortium.com _

p at rdus Kolab work is funded in part by KDAB and the Kolab Konsortium

____ http://www.pardus.de _________________ http://gunnarwrobel.de _
E-mail : p at rdus.de                                 Dr. Gunnar Wrobel
Tel.   : +49 700 6245 0000                          Bundesstrasse 29
Fax    : +49 721 1513 52322                          D-20146 Hamburg
--------------------------------------------------------------------
    >> Mail at ease - Rent a kolab groupware server at p at rdus <<
--------------------------------------------------------------------

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digitale PGP-Unterschrift
URL: <http://lists.kolab.org/pipermail/devel/attachments/20100216/a7dcfd10/attachment.sig>