[Kolab-devel] gunnar: server/kolab-filter/filter config.php, 1.3, 1.4 kolabfilter.php, 1.2, 1.3 kolabmailboxfilter.php, 1.2, 1.3

[Gunnar Wrobel]

Richard Bos <ml at radoeka.nl> writes:

> Op Tuesday 04 December 2007 08:39:20 schreef Richard Bos:
>> What about the explanation of what to do when the file resmgr.conf has been
>> updated.  I think that such a text would be nice to put in the kolab
>> header.   That way it does not show up in the resulting config files
>> (config.php and etc/kolab/resmgr.conf):
>>
>> # head resmgr.conf.template.in
>> KOLAB_META_START
>> TARGET=@resmgr_confdir@/config.php
>> PERMISSIONS=0640
>> OWNERSHIP=@resmgr_conffile_usr@:@resmgr_conffile_grp@
>>
>> # This is an explanation of what to do with this file
>> #
>> # Blah Blah
>>
>> KOLAB_META_END
>> <?php
>>
>>
>> Is my assumption correct, and does the text have no influence on setting
>> the permission, and the owner etc on the file?
>
> I tested it, with a test script (with the code from kolabconf) and it seems to 
> be no problem.  I would like to apply the following diff:
>
> diff -u -r1.19 resmgr.conf.template.in
> --- resmgr.conf.template.in     3 Dec 2007 11:27:19 -0000       1.19
> +++ resmgr.conf.template.in     7 Dec 2007 12:37:59 -0000
> @@ -2,6 +2,19 @@
>  TARGET=@resmgr_confdir@/config.php
>  PERMISSIONS=0640
>  OWNERSHIP=@resmgr_conffile_usr@:@resmgr_conffile_grp@
> +
> +# Update instructions:
> +# --------------------
> +# If this file is being modified, please do the following:
> +# - execute the command: convert_template2config_php.pl
> +# - move the file resmgs.conf_config.php to 
> server/kolab-filter/filter/config.php
> +#
> +# The file server/kolab-filter/filter/config.php is a configuration example
> +# file that is distributed with the kolab-filter module/package.
> +# The purpose of the server/kolab-filter/filter/config.php file is to be
> +# an example configuration file, in case the kolab-filter module/package
> +# is distributed on it's own.
> +
>  KOLAB_META_END
>  <?php
>
> Is it okay to apply?

Yes, that is okay.

I thought about different solutions concerning the location of the
conversion script again.

The main issue I'm having with the current location is the fact that
it incorrectly cross links the kolabd package with the kolab-filter
package.

This is not at all the fault of the template conversion script but
rather a problem of the template itself. Of course the template has
always been in kolabd.

But from a packaging point of view having the configuration file for
kolab-filter within kolabd is simply a defect.

I'd like to suggest moving both the template as well as the conversion
script into "server/kolab-filter/filter/kolab-templates".

This way the template will be packaged together with the source
package and any packager can decide if they wish to use this template
or not. For a real native port the template will have to be installed
into the corresponding /etc/kolab/templates directory.

In order to move the template script variables like @sysconfdir@
have to be converted to @@@sysconfdir@@@ and need to be added to
kolab.conf.

If nobody objects I'd solve the situation this way.

Cheers,

Gunnar

-- 
______ http://kdab.com _______________ http://kolab-konsortium.com _

p at rdus Kolab work is funded in part by KDAB and the Kolab Konsortium

____ http://www.pardus.de _________________ http://gunnarwrobel.de _
E-mail : p at rdus.de                                 Dr. Gunnar Wrobel
Tel.   : +49 40 432 72335                           Bundesstrasse 29
Fax    : +49 40 432 70855                            D-20146 Hamburg
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   >> Mail at ease - Rent a kolab groupware server at p at rdus <<                 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~