[Kolab-devel] gunnar: server/kolab-filter/filter config.php, 1.3, 1.4 kolabfilter.php, 1.2, 1.3 kolabmailboxfilter.php, 1.2, 1.3

[Richard Bos]

Op Tuesday 04 December 2007 06:32:36 schreef Gunnar Wrobel:
> > If you don't mind too much, I'll commit the script into the template
> > directory (if the future proofs otherwise it can be moved to the than
> > better location). If you do mind and insist of having it in
> > template-tools, please let me know (or just commit it yourself into
> > template-tools ;) )
>
> Okay, do it ;)

I want to apply the following patch the convert template tool:
diff -u -r1.1 convert_template2config_php.pl
--- convert_template2config_php.pl      7 Dec 2007 12:22:34 -0000       1.1
+++ convert_template2config_php.pl      7 Dec 2007 12:58:43 -0000
@@ -110,6 +110,20 @@
        # update the script.
        s/\('true/true/;
        s/'=='TRUE'\)//;
+       if (/^\?>$/) {
+         print $config "//!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+//
+// This is a generated file.  The source file is the template file
+// $metatemplates[$file_id] in the kolab cvs module kolabd.
+// The fullname of the source file is:
+// server/kolabd/templates/$metatemplates[$file_id]
+//
+// If you modify this file, please do not forget to modify the above mentioned
+// source file.
+//
+//!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\n";
+       }
+
        print $config $_;


Which results in the following message at the end of the resmgr.conf file:
//!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
//
// This is a generated file.  The source file is the template file
// resmgr.conf.template.in in the kolab cvs module kolabd.
// The fullname of the source file is:
// server/kolabd/templates/resmgr.conf.template.in
//
// If you modify this file, please do not forget to modify the above mentioned
// source file.
//
//!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
?>

Is this text okay?

If this patch is applied the message at the end of resmgr.conf.template.in can be removed.

The template file freebusy.conf.template.in does not trigger the above question, because the "?>" at the end of the file is not present.  Is that a bug?

-- 
Richard Bos
Without a home the journey is endless
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kolab.org/pipermail/devel/attachments/20071207/8ca9c295/attachment.html>