[Kolab-devel] Incorrect patch to transport.template.in and virtual.template.in I believe

Richard Bos radoeka at xs4all.nl
Fri Nov 10 23:45:52 CET 2006


The underneath patch changes the owner hardcoded to root for 
transport.template.in and virtual.template.in, which is not good to my 
opinion.  The @emailserver_usr@ should be changed for kolab or a new 
dist_conf value should be introduced.  The current patch has impact on non 
openpkg distribution.

Should the patch be reverted?

Op vrijdag 10 november 2006 17:08, schreef cvs at kolab.org:
> Author: thomas
>
> Update of /kolabrepository/server/kolabd/kolabd/templates
> In directory doto:/tmp/cvs-serv11171/kolabd/kolabd/templates
>
> Modified Files:
> 	transport.template.in virtual.template.in
> Log Message:
> Issue1433: Some files in /kolab/etc/postfix have wrong ownership.
> Change owner to root in the templates so 'make' doesn't abort with
> permission denied when trying to create virtual.db and transport.db.
>
> 
http://kolab.org/cgi-bin/viewcvs-kolab.cgi/server/kolabd/kolabd/templates/virtual.template.in.diff?r1=1.3&r2=1.4&sortby=date
>
>
> Index: transport.template.in
> ===================================================================
> RCS file:
> /kolabrepository/server/kolabd/kolabd/templates/transport.template.in,v
> retrieving revision 1.3
> retrieving revision 1.4
> diff -u -d -r1.3 -r1.4
> --- transport.template.in	4 Feb 2006 18:19:58 -0000	1.3
> +++ transport.template.in	10 Nov 2006 16:08:20 -0000	1.4
> @@ -1,7 +1,7 @@
>  KOLAB_META_START
>  TARGET=@emailserver_confdir@/transport
>  PERMISSIONS=0640
> -OWNERSHIP=@emailserver_usr@:@emailserver_grp@
> +OWNERSHIP=root:@emailserver_grp@
>  KOLAB_META_END
>  # (c) 2003 Tassilo Erlewein <tassilo.erlewein at erfrakon.de>
>  # (c) 2003 Martin Konold <martin.konold at erfrakon.de>
>
> Index: virtual.template.in
> ===================================================================
> RCS file:
> /kolabrepository/server/kolabd/kolabd/templates/virtual.template.in,v
> retrieving revision 1.3
> retrieving revision 1.4
> diff -u -d -r1.3 -r1.4
> --- virtual.template.in	4 Feb 2006 18:19:58 -0000	1.3
> +++ virtual.template.in	10 Nov 2006 16:08:20 -0000	1.4
> @@ -1,7 +1,7 @@
>  KOLAB_META_START
>  TARGET=@emailserver_confdir@/virtual
>  PERMISSIONS=0640
> -OWNERSHIP=@emailserver_usr@:@emailserver_grp@
> +OWNERSHIP=root:@emailserver_grp@
>  KOLAB_META_END
>  # (c) 2003 Tassilo Erlewein <tassilo.erlewein at erfrakon.de>
>  # (c) 2003 Martin Konold <martin.konold at erfrakon.de>
>
>
> _______________________________________________
> Kolab-commits mailing list
> Kolab-commits at kolab.org
> https://kolab.org/mailman/listinfo/kolab-commits

-- 
Richard Bos
Without a home the journey is endless




More information about the devel mailing list