[Kolab-devel] Bug or feature?

[Steffen Hansen]

On Monday 06 September 2004 21:43, Matt Douhan wrote:
> During the attemtps to add the relay support I ran across the problem
> that when you pass an empty string to the ldap server it fails with a
> "LDAP error, cannot modify kolab object" error, I thought this was me
> doing something wrong and Steffen added some insight as to why it is
> happening.
>
> I noted the same error also happens if you try and delete 127.0.0.0/8
> from the Privilieged networks configuration textbox.
>
> I am not sure if this is a bug or a feature,
>
> Not being able to send an empty string to the priv networks can be
> considered good since it would render the server useless. but at the
> same time it may not be the type of error handling intended.
>
> Worth logging in the bug tracker?

Hehe, my first thought when I saw your other LDAP error was actually
"hmm, I bet I forgot about that for postfix-mynetworks" :-)

The fix is the same as for your problem:

--- kolab-webadmin/www/admin/service/index.php  13 Aug 2004 01:04:16 -0000      1.7
+++ kolab-webadmin/www/admin/service/index.php  6 Sep 2004 20:43:46 -0000
@@ -98,6 +98,7 @@ if( $_REQUEST['submitquotawarn'] ) {
 if( $_REQUEST['submitpostfixmynetworks'] ) {
   $attrs = array();
   $attrs['postfix-mynetworks'] = trim( $_REQUEST['postfixmynetworks'] );
+  if( $attrs['postfix-mynetworks'] == '' ) $attrs['postfix-mynetworks'] = array();
   if( !($result = ldap_modify($ldap->connection, "k=kolab,".$_SESSION['base_dn'], $attrs)) ) {
        $errors[] = _("LDAP Error: failed to modify kolab configuration object: ")
          .ldap_error($ldap->connection);

regards
-- 
Steffen Hansen          |       Klarälvdalens Datakonsult AB
Senior Software Engineer|       http://www.klaralvdalens-datakonsult.se
                        |
                        |       Platform-independent
                        |       software solutions