From mihai at badici.ro Mon Feb 5 09:14:18 2024 From: mihai at badici.ro (Mihai Badici) Date: Mon, 5 Feb 2024 11:14:18 +0200 Subject: changes in addressbook Message-ID: <41779339-25a4-4e42-a907-43931651c329@badici.ro> I started a new test build for roundcube with kolab plugins just to refresh my existing template. I used the current master branch for roundcube and the same for kolab repos. I encountered two new issues till now, I will wrote 2 mails to keep them distinct. In kolab_addressbook, I had this fatal error: Declaration of kolab_contacts::set_search_set($filter) must be compatible with rcube_addressbook::set_search_set($filter): void and Declaration of kolab_contacts::reset() must be compatible with rcube_addressbook::reset() It looks like there is a recent change in roundcube addressbook which declare set_search_set and reset functions as void. This is not reflected in kolab_contacts. I fixed it adding : void to kolab_contacts definitions. Honestly I don't see any big advantage to declare them void but maybe the explicit type will be enforced in php or can be other reasons for that. -------------- next part -------------- An HTML attachment was scrubbed... URL: From mihai at badici.ro Mon Feb 5 09:24:31 2024 From: mihai at badici.ro (Mihai Badici) Date: Mon, 5 Feb 2024 11:24:31 +0200 Subject: kolab_auth Message-ID: Activating kolab_auth in current master roundcube produce this error: LDAP Error: Could not connect to any LDAP server, last tried localhost I found in the code: if (!is_resource($this->conn)) { ?rcube::raise_error(array('code' => 100, 'type' => 'ldap', (etc) But i can't find where conn is set. It looks like it is not set at all .? Since on the test server I don;t care so much I removed this test? and assumed this return true but probably is better to clarify what should be tested here. -------------- next part -------------- An HTML attachment was scrubbed... URL: