[Kolab-devel] More guam fixes in 0.9.7 (with eimap 0.4.2)

[Daniel Hoffend]

Accepted :-)

Sure I'll rebase my guam update.

Regarding the guam package. After the last guam upgrade i realized that
the service guam died and wasn't restarted.

The postinst update basically to ensure that
a) the package stays enable when guam was enabled in the first place
b) systemd gets reloaded if the unit file has changed during installation
c) guam gets started (new installation) or restarted (on upgrade)

Since the dependencies pinning is done during build time there's no need
to rebase.

Once you've reviewed/accepted the package we can push it forward to
Kolab:16 in a 4 eye review process :-)

Have a great weekend.

--
Cheers
Daniel



Am 24.04.2020 um 12:40 schrieb Christian Mollekopf:
> On Wednesday, April 22, 2020 12:42:27 AM CEST you wrote:
>> Hi Christian
>>
>> Thanks for your work!
>>
>> I can confirm that using the patch to support pipelined commands the
>> issue with not beening able to to download attachments has been solved.
> 
> Excellent, thanks for testing.
> 
> I have tagged a 0.4.2 release and created a submit request to winterfell
> from my package.
> 
> I noticed that you have created two requests yourself, but I'm afraid I
> don't fully understand what they are achieving (I just noticed that
> there are significant changes to debian packaging).
> 
> Could you elaborate why your additional changes are necessary?
> 
> In any case I would propose to rebase on top of the 0.4.2 release (once
> my request is accepted).
> 
> Cheers,
> Christian
> 
>> guam 0.9.7 and eimap 0.4.1 are already in Kolab:Winterfell and Kolab:16
>>
>> After comparing your personal 0.4.2 package and the Winterfell 0.4.1
>> version I saw only one missing commit. Due to Debian version pinning I
>> couldn't directly install your eimap version, so I created my own
>> guam+eimap packages and tested them to confirm they're working. (My own
>> mailserver runs them now)
>>
>> http://obs.kolabsys.com/repositories/home:/dhoffend:/branches:/Kolab:/Winterfell/Debian_10.0/amd64/
>>
>>
>> As soon as the patch lands in master we could updated the packages (with
>> with a patch or directly with a new version number) and push them
>> forward.
>>
>>
>> -- 
>> Regards
>> Daniel
>>
>> Am 16.04.2020 um 11:53 schrieb Christian Mollekopf:
>> > Hi,
>> >
>> > Last week I spent some time brushing up my erlang and doing some guam
>> > development.
>> >
>> > There is now a test-suite that should cover all the patches that have
>> > accumulated over the past years and have been integrated into 0.9.6
>> >
>> > I then also looked into some issues with clients that pipeline commands
>> > (that means they just send multiple commands at once without waiting
>> for
>> > a reply from the server, which can be valid depending on the commands).
>> >
>> > This lead to the following changes lined up for guam 0.9.7 and eimap
>> 0.4.2:
>> > * Commands coming from the client are now processed line by line, so
>> > pipelined commands that end up in the same network packet are processed
>> > correctly.
>> > * The same would have to happen with replies coming from the server,
>> > which lead to a patch for eimap (lined up for 0.4.2), that doesn't
>> quite
>> > do that correctly, but fixes the one bug that I found related to this
>> > (the getmetadata processing necessary for filtering of groupware
>> folders).
>> >
>> > This also allowed me to remove some odd workarounds that we started to
>> > accumulate in various places, while hopefully not re-introducing any
>> > failures (since the relevant scenarios are covered by tests now).
>> >
>> > Another significant change is that I have enabled two debug messages
>> > logging all traffic (after terminating ssl and decompressing) from
>> > client and server, which means the "debug" level which is not
>> enabled by
>> > default will be a *lot* noisier, but also finally useful for collecting
>> > the necessary info that we require for reproducing issues. I think this
>> > could be further enhanced with a logging feature called tracing,
>> > allowing to collect output from only certain messages in a separate
>> file.
>> >
>> > Guam 0.9.7 should already be in winterfell, for eimap 0.4.2 you can
>> find
>> > packages here:
>> >
>> http://obs.kolabsys.com/repositories/home:/mollekopf:/branches:/Kolab:/Winterfell/
>>
>> >
>> >
>> > Let me know if you run into new or further issues.
>> >
>> > Cheers,
>> > Christian
>> >
>> > _______________________________________________
>> > devel mailing list
>> > devel at lists.kolab.org
>> > https://lists.kolab.org/mailman/listinfo/devel
>> >
>> _______________________________________________
>> devel mailing list
>> devel at lists.kolab.org
>> https://lists.kolab.org/mailman/listinfo/devel
>>