[Kolab-devel] patches for cyrus?

[Richard Bos]

Hello Thomas,

Op dinsdag 07 oktober 200909:22:59  schreef Thomas Arendsen Hein:
> The OpenPKG imapd.spec file contains this:
>
> %if "%{with_ldap}" == "yes"
>     %{l_shtool} subst -e 's;\(IMAP_LIBS="${LIB_SASL}\) \(.*"\);\1 -lldap -
llber \2;g' configure
> %endif
>
> So it just patches the configure file on demand.

that's helps a lot.  I get a cyrus package this way as well :)

Now when I leave the configure arguments "--with-ldap=%{_includedir}" with the 
configure command line, I get the following RPMLINT check error
(the error is on the bottom of the following output):

cyrus-imapd> cat RPMLINT_ERROR
..........
Wrote: /usr/src/packages/SRPMS/cyrus-imapd-kolab-2.3.14-7.src.rpm                                                                                    
Wrote: /usr/src/packages/RPMS/i586/cyrus-imapd-kolab-2.3.14-7.i586.rpm                                                                               
Wrote: /usr/src/packages/RPMS/i586/perl-Cyrus-IMAP-2.3.14-7.i586.rpm
Wrote: /usr/src/packages/RPMS/i586/perl-Cyrus-SIEVE-
managesieve-2.3.14-7.i586.rpm
Wrote: /usr/src/packages/RPMS/i586/cyrus-imapd-kolab-devel-2.3.14-7.i586.rpm
... checking for files with abuild user/group
... running 00-check-install-rpms
... installing all built rpms
error: failed to stat /sys/kernel/debug: No such file or directory
Preparing packages for installation...
perl-Cyrus-IMAP-2.3.14-7
perl-Cyrus-SIEVE-managesieve-2.3.14-7
cyrus-imapd-kolab-devel-2.3.14-7
cyrus-imapd-kolab-2.3.14-7
... running 01-check-debuginfo
... testing for empty debuginfo packages
... running 02-check-gcc-output
... testing for serious compiler warnings
    (using /usr/lib/build/checks-data/check_gcc_output)
    (using /var/tmp/build-root-openSUSE_11.1-i586/.build.log)

I: Program returns random data in a function
E: cyrus-imapd-kolab no-return-in-nonvoid-function afskrb.c:549


I solved it by using this patch:
--- ./cyrus-imapd-2.3.14/ptclient/afskrb.c      2008-03-24 19:34:22.000000000 
+0100
+++ ./cyrus-imapd-2.3.14.new/ptclient/afskrb.c  2009-10-07 20:00:07.000000000 
+0200
@@ -546,6 +546,7 @@
     int *dsize __attribute__((unused)))
 {
        fatal("PTS module (afskrb) not compiled in", EC_CONFIG);
+       return 0;
 }

 #endif /* HAVE_AFSKRB */


Just wondering if that is the correct way to solve that RPMLINT error (cyrus-
imapd-kolab no-return-in-nonvoid-function afskrb.c:549).

For clarity, I'm not going to use the --with-ldap argument in the configure 
line, I just came across it (the error).  It also shows that the --with-ldap 
leaves out, part of the code.  Don't know if that is desired.....


-- 
Richard