[Kolab-devel] Failing php tests for kolab

[Richard Bos]

Op maandag 09 februari 2009 17:37:33 schreef Gunnar Wrobel:
> Quoting Richard Bos <ml at radoeka.nl>:
> > Hi,
> >
> > I just ran tests that come with the kolab pear packages and some tests
> > are failing.  Hence I have some questions related to this.  Please find
> > the failing tests in the attachment.  This is btw on native openSUSE_11.1
> >
> > Tests seem to fail because the file Horde/Kolab/Test.php is not present;
> > What module provides the file Horde/Kolab/Test.php?
>
> That file has been removed. I think some of the tests need to be fixed
> upstream. I hope to be able to look at that soon.
>
> > A test complains that the class Horde_Kolab_IMAP is not present;
> > What module provides the class Horde_Kolab_IMAP?
> >
> > A test complains that the class Horde_Kolab_Server is not present;
> > What module provides the class Horde_Kolab_Server?
> >  Is this package
> > http://pear.horde.org/index.php?package=Horde_Kolab_Server required?  The
> > same question for Horde_Kolab_Format  (those 2
> > packages seem to
> > he superseeded by just kolab_format and kolab_server, hence my question
> > about the ones prefixed with Horde_*).
>
> The Horde_Kolab_* packages are indeed deprecated. Only the Kolab_*
> ones are relevant.

Is it possible to patch this upstream:
=== /usr/share/php5/PEAR/Horde/Kolab/IMAP/test.php ===                                                                                         
PHP Fatal error:  Class 'Horde_Kolab_IMAP' not found in /usr/share/php5/PEAR/Horde/Kolab/IMAP/test.php on line 27                              

kolab:/usr/share/php5 # diff -u /usr/share/php5/PEAR/Horde/Kolab/IMAP/test.php.org /usr/share/php5/PEAR/Horde/Kolab/IMAP/test.php
--- /usr/share/php5/PEAR/Horde/Kolab/IMAP/test.php.org  2009-02-17 22:45:39.000000000 +0100                                      
+++ /usr/share/php5/PEAR/Horde/Kolab/IMAP/test.php      2009-02-17 22:45:03.000000000 +0100                                      
@@ -5,6 +5,7 @@                                                                                                                  
  * $Horde: framework/Kolab_Server/lib/Horde/Kolab/IMAP/test.php,v 1.1.2.1 2008/10/27 09:50:35 wrobel Exp $                      
  */                                                                                                                             
                                                                                                                                 
+require_once('Horde/Kolab/IMAP.php');                                                                                           
 /**                                                                                                                             
  * Indicate that a mail has been marked as deleted                                                                              
  */                                                                                                                             


The same for this one:
kolab:/usr/share/php5 # php /srv/www/htdocs/horde/lib/Horde/Kolab/Server/ldap.php
PHP Fatal error:  Class 'Horde_Kolab_Server' not found in /srv/www/htdocs/horde/lib/Horde/Kolab/Server/ldap.php on line 27

kolab:/usr/share/php5 # diff -u /srv/www/htdocs/horde/lib/Horde/Kolab/Server/ldap.php 
/srv/www/htdocs/horde/lib/Horde/Kolab/Server/ldap.php.new--- /srv/www/htdocs/horde/lib/Horde/Kolab/Server/ldap.php       2009-02-17 
22:52:51.000000000 +0100
+++ /srv/www/htdocs/horde/lib/Horde/Kolab/Server/ldap.php.new   2009-02-17 22:51:41.000000000 +0100
@@ -9,6 +9,7 @@

 /** We need the Horde LDAP tools for this class **/
 require_once 'Horde/LDAP.php';
+require_once 'Horde/Kolab/Server.php';

-- 
Richard