[Kolab-devel] kolab-freebusy / CN in fb-vcal files

[Gunnar Wrobel]

Hi Mike,

Mike Gabriel <m.gabriel at das-netzwerkteam.de> writes:

> hi gunnar, hi kolab-developers,
>
> i looked into the freebusy code a bit closer still. it looks like the only way  
> to retrieve a CN that belongs to $access->owner is to query HordePrefs or 
> Kolab-LDAP from within the freebusy scripts.
>
> the below message was already posted on kolab-users...
>
> mike 
>
> ----------  Weitergeleitete Nachricht  ----------
>
> Betreff: Re: freebusy with kolab debian packages
> Datum: Mittwoch 20 Februar 2008
> Von: Mike Gabriel <m.gabriel at das-netzwerkteam.de>
> An: Gunnar Wrobel <wrobel at pardus.de>
>
> hi gunnar,
>
> Quoting Gunnar Wrobel <wrobel at pardus.de>:
>
>>> in my lib/Horde/iCalendar/vfreebusy.php (horde-3.2-rc1)
>>> Horde_iCalendar_vfreebusy::getName() does not return a valid friendly
>>> name for the ORGANIZER. this probably is mainly due to a missing CN
>>> param for the ORGANIZER in my freebusy cache files generated by the
>>> kolab-2.2 freebusy engine (i backported fb scripts from kolab-2.2 to
>>> kolab-2.1).
>>>
>>> is it intended that the ORGANIZER's CN is missing in the vcal files?
>>
>> No, if remember it correctly the entry is mandatory. I would have to
>> check again but maybe you have a hint why this is missing in the cache
>> files?
>
> here is an example of a fb-vcal file/header generated by your  
> php-script (i have removed most of the FREEBUSY fields...):
>
> EGIN:VCALENDAR
> VERSION:2.0
> PRODID:-//proko2//freebusy 1.0//EN
> METHOD:PUBLISH
> BEGIN:VFREEBUSY
> ORGANIZER:MAILTO:m.gabriel at das-netzwerkteam.de
> DTSTAMP:20080220T102236Z
> URL:http://mail.das-netzwerkteam.de/freebusy/m.gabriel@das-n
>   etzwerkteam.de.vfb
> DTSTART:20080219T000000Z
> DTEND:20080420T000000Z
> FREEBUSY:20080219T070000Z/20080219T080000Z
> ...
> FREEBUSY:20080418T160000Z/20080418T200000Z
> END:VFREEBUSY
> END:VCALENDAR
>
> however, ORGANIZER:CN is probably not set as there is no setAttribute  
> call in any of you FB-php-files setting a CN metadata attribute. would  
> be nice to have a CN, though.

I added patches to both Horde CVS and Kolab CVS to support the CN:

http://cvs.horde.org/diff.php?r1=1.5&r2=1.6&f=framework%2FKolab%2FKolab%2FLDAP.php
http://kolab.org/cgi-bin/viewcvs-kolab.cgi/server/php-kolab/Kolab_Freebusy/Freebusy/Cache.php.diff?r1=1.7&r2=1.8
http://kolab.org/cgi-bin/viewcvs-kolab.cgi/server/php-kolab/Kolab_Freebusy/Freebusy/Page.php.diff?r1=1.5&r2=1.6

I also checked the iCal specs:

http://www.kanzaki.com/docs/ical/organizer.html

=>

  organizer  = "ORGANIZER" orgparam ":"
               cal-address CRLF

  orgparam   = *(

             ; the following are optional,
             ; but MUST NOT occur more than once

             (";" cnparam) / (";" dirparam) / (";" sentbyparam) /
             (";" languageparam) /

             ; the following is optional,
             ; and MAY occur more than once

             (";" xparam)

             )

The CN entry is NOT required.

You originally stated that:

>>> Horde_iCalendar_vfreebusy::getName() does not return a valid friendly
>>> name for the ORGANIZER. this probably is mainly due to a missing CN
>>> param for the ORGANIZER in my freebusy cache files generated by the
>>> kolab-2.2 freebusy engine (i backported fb scripts from kolab-2.2 to
>>> kolab-2.1).

What is the exact error that led to your assumption? Do the patches I
mentioned above fix the problem?

I looked briefly at the vfreebusy.php code but I'm not certain that a
missing CN would indeed make the code. I think getName() should only
return an empty string then which seems to be fine.

Cheers,

Gunnar



>
>
>> P.S.: Thanks for reading and correcting the code!
>>
>
> no problem!!!
>
> mike
>
> ----------------------------------------------------------------
> This message was sent using IMP, the Internet Messaging Program.
>
> _______________________________________________
> Kolab-users mailing list
> Kolab-users at kolab.org
> https://kolab.org/mailman/listinfo/kolab-users
>
> -------------------------------------------------------
>
> -- 
>
> +++ das-netzwerkteam.de +++
>
> mike gabriel, hamburger chaussee 240, 24113 kiel
> fon: +49 431 64-74-196
> fax: +49 431 64-74-276
> voip/voicemail: +49 431 643 643 6
> mail: m.gabriel at das-netzwerkteam.de
> www: http://das-netzwerkteam.de
> _______________________________________________
> Kolab-devel mailing list
> Kolab-devel at kolab.org
> https://kolab.org/mailman/listinfo/kolab-devel

-- 
______ http://kdab.com _______________ http://kolab-konsortium.com _

p at rdus Kolab work is funded in part by KDAB and the Kolab Konsortium

____ http://www.pardus.de _________________ http://gunnarwrobel.de _
E-mail : p at rdus.de                                 Dr. Gunnar Wrobel
Tel.   : +49 700 6245 0000                          Bundesstrasse 29
Fax    : +49 721 1513 52322                          D-20146 Hamburg
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   >> Mail at ease - Rent a kolab groupware server at p at rdus <<                 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~