[Kolab-devel] start using configure's --htmldir to define the webserver directory location (spec file update needed)

[Gunnar Wrobel]

Hi Richard,

Richard Bos <ml at radoeka.nl> writes:

> summary: 
>
> start using configure's --htmldir to define the webserver directory location.
> There is one caveat though, about using --htmldir for this purpose, the
> argument is originally meant to define the html documentation directory.
> The reason to use --htmldir to define the webserver directory, is because:
> DISTCHECK_CONFIGURE_FLAGS="--with-dist=suse --without-openpkg" make distcheck
> fails.  Extended explanation included below. 
>
> Current kolab-webadmin setup, create tarbal:
> kolab-webadmin> ./bootstrap
> kolab-webadmin> ./configure --without-openpkg --with-dist=suse
> kolab-webadmin> make distcheck > out 2>&1
> kolab-webadmin> grep -c openpkg out
> 144
> This is not good, as there should be no openpkg reference due to
> the --without-openpkg argument.
>
> The correct way to execute 'make distcheck' is therefor:
> kolab-webadmin> DISTCHECK_CONFIGURE_FLAGS="--with-dist=suse --without-openpkg" make distcheck > out 2>&1
> kolab-webadmin> grep -c openpkg out
> 0
> This is good, but now 'make distcheck' fails:
> kolab-webadmin> tail -7 out
> test -z "/srv/www/htdocs/kolab/admin/pics" || /bin/mkdir -p "/srv/www/htdocs/kolab/admin/pics"
> /bin/mkdir: cannot create directory `/srv/www/htdocs/kolab': Permission denied
> make[2]: *** [install-dist_wspicsDATA] Error 1
> make[2]: Leaving directory `/var/tmp/kolab/kolab-webadmin/kolab-webadmin/kolab-webadmin-2.1.99/_build'
> make[1]: *** [install-am] Error 2
> make[1]: Leaving directory `/var/tmp/kolab/kolab-webadmin/kolab-webadmin/kolab-webadmin-2.1.99/_build'
> make: *** [distcheck] Error 2
>
> The reason is the definition of the webserver directory in Makefile.am
> kolab-webadmin> grep -n webserver_document_root Makefile.am
> 21:wstopleveldir = $(webserver_document_root)$(webserver_web_prefix)
> 29:wskolabdir = $(webserver_document_root)$(webserver_web_prefix)/admin
>
> This definition does not take the destination directory into account.
> Whatever I tried to change the behaviour of automake, I did not get it correct.
> I tried e.g.:
> $(distdir)/$(webserver_document_root)$(webserver_web_prefix)
> $(DESTDIR)/$(webserver_document_root)$(webserver_web_prefix)
> $(prefix)$(DESTDIR)/$(webserver_document_root)$(webserver_web_prefix)
> $(DESTDIR)/$(prefix)/$(webserver_document_root)$(webserver_web_prefix)
> The changes above result in a working distcheck, but not in a correct
> behaving: 'make install DESTDIR=....'.
>
> When 
> 21:wstopleveldir = $(webserver_document_root)$(webserver_web_prefix)
> 29:wskolabdir = $(webserver_document_root)$(webserver_web_prefix)/admin
> is changed to:
> 21:wstopleveldir = $(htmldir)$(webserver_web_prefix)
> 29:wskolabdir = $(htmldir)$(webserver_web_prefix)/admin
> make distcheck works as well
> make install DESTDIR=.....
>
> However it means that the webserver directory is to be defined as configure
> argument instead of being defined in the dist_conf/<distribution> file.  This
> means that the packagers have to update their kolab-webadmin specfile.
>
> May I go ahead and make this change?

I'm neither opposed or in favor of this. As you know I still intend to
rewrite this thing because it is currently still very broken. We need
this to be a real web application that can be installed on just any
virtual host.

Just hold on the change until we have RC2 out. If you are certain it
does not damage the OpenPKG install and it helps you on SuSE, commit
it right after that.

Cheers,

Gunnar

>
> -- 
> Richard Bos
> Without a home the journey is endless
>
> _______________________________________________
> Kolab-devel mailing list
> Kolab-devel at kolab.org
> https://kolab.org/mailman/listinfo/kolab-devel

-- 
______ http://kdab.com _______________ http://kolab-konsortium.com _

p at rdus Kolab work is funded in part by KDAB and the Kolab Konsortium

____ http://www.pardus.de _________________ http://gunnarwrobel.de _
E-mail : p at rdus.de                                 Dr. Gunnar Wrobel
Tel.   : +49 700 6245 0000                          Bundesstrasse 29
Fax    : +49 721 1513 52322                          D-20146 Hamburg
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   >> Mail at ease - Rent a kolab groupware server at p at rdus <<                 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~