[Kolab-devel] gunnar: server/file kolab-filemagic.patch, 1.2, 1.3

Bernhard Reiter bernhard at intevation.de
Tue Oct 16 11:34:50 CEST 2007


On Monday 15 October 2007 18:51, Thomas Arendsen Hein wrote:
> * Bernhard Reiter <bernhard at intevation.de> [20071015 15:27]:
> > > Added Files:
> > >         kolab-filemagic.patch
> > > Log Message:
> > > Reverted. This file is a reminder to include this.
> >
> > What do you mean by "include this"?
> > Note that if this should go upstream (step OpenPGK, step file
> > developers),
>
> OpenPKG refused to include this patch, because they regard it as a
> problem of the interpretation of file's output for mail filtering
> with the default setup of Kolab.

I disagree, "file" with these patterns enabled produced 
too many false positives.

> > we should have a "merge" issue created.
>
> Maybe, see below.

We should document the case and the refusals if they come from 
OpenPKG and upstream.

> * Thomas Arendsen Hein <thomas at intevation.de> [20071015 18:41]:
> > The removal of the patch was already reverted, so the patch stays
> > there as a reminder to integrate it in a different way:
> >
> > The plan is to either convince file's upstream, or add a custom
> > magic file as a template to kolabd.
>
> Convincing file's upstream to drop one pattern which indicates .com
> files might be hard (for a good reason), additionally the custom
> magic template would give us more control about what we feed to
> amavisd.
>
> So I actually would prefer the second solution, and this won't
> involve a merge issue.

The problem with file stays for other purposes as well.
The custom filemagic would add maintenance load on us,
but it has the advantage that it would work with other "file"s
as well. There is the risk that other file implementations will
not grok this magic file though.

First: I think we should write a short test that can be run and will
tell us if the file implementation used for amavisd will have this problem.
This way we can warn all Kolab Server users.

Bernhard


-- 
Managing Director - Owner: www.intevation.net       (Free Software Company)
Germany Coordinator: fsfeurope.org. Coordinator: www.Kolab-Konsortium.com.
Intevation GmbH, Osnabrück, DE; Amtsgericht Osnabrück, HRB 18998
Geschäftsführer Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.kolab.org/pipermail/devel/attachments/20071016/90f1ea55/attachment.sig>


More information about the devel mailing list