[Kolab-devel] gunnar: server/kolab-freebusy/freebusy config.php, 1.3, 1.4

[Gunnar Wrobel]

Richard Bos <richard at radoeka.nl> writes:

> Hi,
>
> shouldn't this (see below) have a "//FIXME:  not autoconfigured - still 
> hardcoded"?
>
> Op zondag 14 oktober 2007 14:32, schreef cvs at kolab.org:
>> Index: config.php
>> ===================================================================
>> RCS file: /kolabrepository/server/kolab-freebusy/freebusy/config.php,v
>> retrieving revision 1.3
>> retrieving revision 1.4
>> diff -u -d -r1.3 -r1.4
>> --- config.php  8 Aug 2007 15:45:49 -0000       1.3
>> +++ config.php  14 Oct 2007 12:31:58 -0000      1.4
>> @@ -113,7 +113,7 @@
>>  $params['send_content_disposition'] = false;
>>  
>>  // Where are we logging to?
>> -$params['log'] = 'file:/kolab/var/apache2/log/freebusy/freebusy.log';    
>>            // File... +$params['log'] =
>> 'file:/kolab/var/apache/log/freebusy/freebusy.log';                //
>> File... // $params['log'] = 'syslog:cons, pid';            // Or syslog... 
>>  // What level of output should we log? Higher levels give more verbose
>> output.
>
> $params['log'] = 'file://@freebusy_logfile@'
> This means that config.php should be moved to config.php.in

No. kolab-freebusy does not use the dist_conf mechanism. It only uses
the config file for configuration. And that get's rewritten via a
template. So you need to check the template version in kolabd.

>
> Same here:
>> Index: kolabsrv.in
>> ===================================================================
>> RCS file: /kolabrepository/server/kolabd/kolabd/dist_conf/kolabsrv.in,v
>> retrieving revision 1.7
>> retrieving revision 1.8
>> diff -u -d -r1.7 -r1.8
>> --- kolabsrv.in 11 Mar 2006 21:39:16 -0000      1.7
>> +++ kolabsrv.in 14 Oct 2007 12:31:58 -0000      1.8
>> @@ -38,7 +38,7 @@
>>  esac
>>  
>>  if [[ "$2" == "all" ]]; then
>> -       SERVICES="@LDAPD@ slurpd saslauthd spamd amavis apache2 freshclam
>> clamd cyrus postfix" +       SERVICES="@LDAPD@ slurpd saslauthd spamd
>> amavis apache freshclam clamd cyrus postfix"
>
> We should add a @APACHED@ variable in case of suse it is 'apache2'
> Just @APACHED@ and that's it.

I will have to check this again. Thanks for the note.

>
> Not sure about this one:
> Op zondag 14 oktober 2007 14:32, schreef cvs at kolab.org:
>> --- Conf.pm     8 Oct 2007 15:38:05 -0000       1.10
>> +++ Conf.pm     14 Oct 2007 12:31:58 -0000      1.11
>> @@ -230,8 +230,8 @@
>>                  $haschanged{'postfix'} = 1;
>>              } elsif ($cfg =~ /saslauthd/) {
>>                  $haschanged{'saslauthd'} = 1;
>> -            } elsif ($cfg =~ /apache2/) {
>> -                $haschanged{'apache2'} = 1;
>> +            } elsif ($cfg =~ /apache/) {
>> +                $haschanged{'apache'} = 1;
>
> should @APACHED@ be used?  If so Conf.pm should be moved to Conf.pm.in

No and yes :) The new kolabconf package is also a package that is not
using the dist_conf mechanism anymore. This is not 100% clean because
of the stanza you commented on. This function needs to be
removed. With the new support for service restarts in the templates
this can actually be done. I just didn't want to remove it for the
Kolab2/OpenPKG version at the moment. This would require to fix all
the templates.

The general direction I'm aiming at is to fully remove the dist_conf
mechanism. It was extremely good for allowing us to port Kolab to
other distributions. But it would not have been necessary at all if
the Kolab specific packages would have adhered to common coding
conventions in the first place. Things like perl-kolab or the old
kolab-resource-handlers simply did not care about packaging because
this was all done in a self containted OpenPKG world.

The changes necessary for this are of course time intensive but so far
perl-kolab, kolabconf, the new php-kolab, kolab-filter and
kolab-freebusy do already follow the conventions appropriate for
packages in the respective language.

>
> We (in this case opensuse) don't care about the apache config file (httpd.conf 
> template) as we provide our own file that is "sourced in" by the config file 
> that is provided by opensuse.

Same on Gentoo. The current Kolab2/OpenPKG configuration is pretty
unflexible and should probably be changed at some point.

Cheers,

Gunnar

>
> -- 
> Richard Bos
> Without a home the journey is endless
>
> _______________________________________________
> Kolab-devel mailing list
> Kolab-devel at kolab.org
> https://kolab.org/mailman/listinfo/kolab-devel

-- 
______ http://kdab.com _______________ http://kolab-konsortium.com _

p at rdus Kolab work is funded in part by KDAB and the Kolab Konsortium

____ http://www.pardus.de _________________ http://gunnarwrobel.de _
E-mail : p at rdus.de                                 Dr. Gunnar Wrobel
Tel.   : +49 40 432 72335                           Bundesstrasse 29
Fax    : +49 40 432 70855                            D-20146 Hamburg
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   >> Mail at ease - Rent a kolab groupware server at p at rdus <<                 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~