[Kolab-devel] freebusy: wrong value for $params['cache_dir']

Gunnar Wrobel wrobel at pardus.de
Wed Nov 22 12:38:53 CET 2006


Hi Sacha, 

> Gunnar changed $params['cache_dir'] to @freebusy_cachedir@ (see
> changelog entry 2006-11-01).
>
> This seems wrong to me as $params['cache_dir'] is always used in
> connection with $params['kolab_prefix']  while @freebusy_cachedir@
> already includes the prefix (at least for the OpenPKG based default
> distribution).
>
> See Issue1490 for details on the problems caused by that.

I just realized this morning that I overlooked the way pfb.php uses
the 'cache_dir' parameter. 

I don't see a specific reason to use the $params['kolab_prefix'] value
and I believe that was just introduced into the pfb.php code because
it was used this way in the original patch
(http://kolab.org/cgi-bin/viewcvs-kolab.cgi/server/kolab-resource-handlers/freebusy-imap-caching.patch?rev=1.1&content-type=text/vnd.viewcvs-markup). But
it breaks compatibility with the autoconfiguration process on the
other distros.

I removed the problematic part from pfb.php and the cache dir should
now be only set using 'cache_dir'.

Cheers, 

Gunnar



-- 
____ http://www.pardus.de _________________ http://gunnarwrobel.de _

E-mail : wrobel at pardus.de                          Dr. Gunnar Wrobel
Tel.   : +49 40 432 72335                      Hartwig-Hesse Str. 12
Fax    : +49 40 432 70855                            D-20257 Hamburg
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  >> Mail at ease - Kolab out of the box <<                 P at rdus
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~




More information about the devel mailing list