[Kolab-devel] Kolab-resource-handlers dependency on Horde libraries

[Gunnar Wrobel]

Bernhard Reiter <bernhard at intevation.de> writes:

> Am Mittwoch, 12. April 2006 10:36 schrieb Gunnar Wrobel:
>> Martin Konold <martin.konold at erfrakon.de> writes:
>> > I applied the patch to CVS.
>>
>> As I mentioned in my last email the kolab-resource-handlers will then
>> depend on the horde-3.1.1 version. Right now kolab lacks this
>> version. The import of the "String" module that has now been added to
>> the resource handler will fail without it.
>
> So your patch break current OpenPKG install?
> If so, can you prove it, so it does not break it?

Maybe we misunderstood each other. The patch certainly breaks the
current OpenPKG install *if* it lacks the corresponding horde code
(current release 3.1.1) and without the new horde version there is no
reason to include it. 

The original thread discussing the horde framework problem

http://www.kolab.org/pipermail/kolab-devel/2005-October/004519.html
http://www.kolab.org/pipermail/kolab-devel/2005-October/004510.html

described the issues with the current kolab-horde-framework package:

1) The code is two years old and has seen none of the security patches
   that have been included in the current horde version.

2) The code is based on a cvs fork from horde with modifications added
   by CodeFusion. It has been unkown what the modifications actually
   were so that moving to the current horde version is difficult if
   not impossible because loosing the modifications to the horde
   libraries would probably break the kolab code that depends on it.

The freebusy and resmgr implementation require several of the horde
libraries and a complete removal of the horde dependency does not seem
reasonable.

If I understood it correctly there was an interest in solving issue 2)
in order to allow fixing issue 1).

I did analyze the sources originally imported into kolab cvs and
determined the date it has been forked from horde cvs as
29/05/2004. By comparing the imported sources against the horde cvs I
was able to determine the changes to horde that have been added by
CodeFusion. While residing in the kolab cvs there have been additional
changes added by Steffen which I also extracted.

Since the cumulated changes were not massive I did transfer the patch
to the current horde-3.1.1 version. I attached this patch again.

The patch only changes two files within the horde libraries:

 - horde-3.1.1/lib/Horde/iCalendar/vfreebusy.php
 - horde-3.1.1/lib/Horde/iCalendar.php

The patch to vfreebusy.php is simple since this particular file has
not changed at all during the last two years. So the fixes by
CodeFusion apply to the new version as well as to the old one.

The patch to the iCalendar.php file is more complex and should get a
review by Steffen, especially since most of the changes contained in
this patch were added by him.

But ultimately this allows to exchange the dependency of the current
kolab-resource-handlers package on the old kolab-horde-framework to a
patched version of current horde. Thus it would solve issue 1) and
provides a clearer idea of the code changes that the kolab project
added to the horde framework.

Only applying the kolab side of the patch without including the horde
part will not work and I would suggest to simply revert the patch for
now until Steffen had a chance to look at the horde side of things.

Regards, 

Gunnar

-------------- next part --------------
A non-text attachment was scrubbed...
Name: kolab-horde-framework-iCalendar-3.1.1.patch
Type: text/x-patch
Size: 8840 bytes
Desc: iCalendar patch for horde-3.1.1
URL: <http://lists.kolab.org/pipermail/devel/attachments/20060412/f258f750/attachment.bin>
-------------- next part --------------

-- 
Gunnar Wrobel                    Gentoo Developer
__________________C_o_n_t_a_c_t__________________

Mail: wrobel at gentoo.org
WWW:  http://www.gunnarwrobel.de
IRC:  #gentoo-web at freenode.org
_________________________________________________