[Kolab-devel] next patch, this time for kolab-webadmin and kolabd

Richard Bos radoeka at xs4all.nl
Thu Nov 24 22:30:59 CET 2005


Steffen (but other interested parties as well ;)

1 of the changes in the patch is removing something without putting anything 
else back for it.  In case of kolab this is okay.  A chown is removed from 
the makefile, because it breaks 'make distcheck' on (build)systems that did 
not create the particular user.  In case of kolab the 'chown' is already done 
in the rpm spec file :)

ChangeLog:
Op dinsdag 22 november 2005 23:10, schreef Richard Bos:
> +         Removed test -z "$(webserver_usr)" || chown $(webserver_usr)
> +         so make distcheck completes.  This should be handled by rpm or
> +         an external script.  In case an rpm is build it is very likely
> +         that the user used in chown is not present.


Makefile.am
+	$(mkinstalldirs) $(DESTDIR)$(phpkolabdir)/templates_c
+# 	test -z "$(webserver_usr)" || chown $(webserver_usr) 
$(DESTDIR)$(phpkolabdir)/templates_c

rpm spec file:
    #   generate file list
    %{l_rpmtool} files -v -ofiles -r$RPM_BUILD_ROOT %{l_files_std} \
        %dir '%defattr(-,%{l_nusr},%{l_ngrp})' 
%{l_prefix}/var/kolab/php/admin/templates_c

Other distributions should do the same trick, chown the file/directory in the 
spec file.


-- 
Richard Bos
Without a home the journey is endless




More information about the devel mailing list