[Kolab-devel] Re: steffen: server/kolab-webadmin/kolab-webadmin/php/admin/include form.class.php, 1.18, 1.19

[Bernhard Herzog]

cvs at intevation.de writes:

> Fix for issue813 (password intry not of type password)
[...]
> --- form.class.php	16 Jun 2005 00:32:10 -0000	1.18
> +++ form.class.php	20 Jun 2005 11:07:00 -0000	1.19
> @@ -67,14 +67,14 @@
>        if( !isset( $value['value'] ) ) $value['value'] = '';
>        switch( $value['type'] ) {
>        case 'hidden': continue;
> +      case '':
> +        // Default is text
> +        $value['type'] = 'text';
>        case 'password':
>  		if( ereg( 'readonly', $value['attrs'] ) ) {		  
>  		  // If readonly, skip it -- passwords are at most write-only
>  		  break;
>  		}
> -      case '':
> -		// Default is text
> -		$value['type'] = 'text';

Are you sure that's the right fix?  With this change, fields that have
no type and which are read only will be skipped which wasn't the case
before.

   Bernhard

-- 
Intevation GmbH                                 http://intevation.de/
Skencil                                           http://skencil.org/
Thuban                                  http://thuban.intevation.org/