[Kolab-devel] [PATCH] smtp auth support for smarthost/relayhost

[Martin Konold]

Am Montag, 1. November 2004 18:09 schrieb Hendrik Muhs:

Hi Hendrik,

> I added smtp authentication support for the smarthost/relayhost feature of
> postfix (forwarding all mails to a specified mailserver).

IMHO this is a very useful feature which deserves consideration for addition 
to Kolab 2 though it needs some refinement.

> Conf.pm.patch (/kolab/lib/perl/vendor_perl/5.8.4/Kolab/Conf.pm)
> This one adds code to create the password hash file.

How do you intend to protect the password in the LDAP directory? This is a 
critical point in your patch.

> index.php.patch (/kolab/var/kolab/www/admin/service/index.php)
> Webadmin code to save postfix-relayhost-user and postfix-relayhost-password
> into LDAP

This is fine.

> service.tpl.patch (/kolab/var/kolab/php/admin/templates/en/service.tpl)
> this adds the input fields in the html code.

Fine!

> kolab2.schema.patch (/kolab/etc/openldap/schema/kolab2.schema)
> adds the LDAP entrys for postfix-relayhost-user and
> postfix-relayhost-password

Fine!

> main.cf.template.patch (/kolab/etc/kolab/templates/main.cf.template)
> adds the necessary postfix configuration parameters for smtp auth

will this hurt for people not using your feature? 
Please never use the hardcoded /kolab prefix.

> saslpasswd.template ((/kolab/etc/kolab/templates/saslpasswd.template)
> simply the empty template for the password file.

The copyright notice is incorrectly claiming copyright for Tassilo and me.

> As I am not an expert on kolab, perl, LDAP I am not sure if the patches
> break something for other users.

We need some testing for this and we must be aware of security issues e.g. 
password protection.

> Anyway, I think it is a nice feature and I hope you will accept my patches

I am willing to have another look later after feeling more confident about 
security implications.

Regards,
-- martin

"I am committed to helping Ohio deliver its electoral votes to the
President next year."  -- Wally O'Dell - CEO of Diebold, Inc. 
e r f r a k o n
Erlewein, Frank, Konold & Partner - Beratende Ingenieure und Physiker