Branch 'kolab/integration/4.13.0' - incidenceeditor-ng/editoritemmanager.cpp

Christian Mollekopf mollekopf at kolabsys.com
Thu Jan 8 14:55:49 CET 2015


 incidenceeditor-ng/editoritemmanager.cpp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 622dad4c776a0a69b4ac02d6ddc3ef61ec99b80e
Author: Sandro Knauß <knauss at kolabsys.com>
Date:   Thu Jan 8 13:22:09 2015 +0100

    incidence editor fails if hitting apply for create incidences
    
    Creating an event and hitting apply button make korganizer crash:
    ASSERT: "item.isValid()" in file
    kdepim/incidenceeditor-ng/incidencedialog.cpp,
    line 487
    
    The problem is that editoritemmanager do trigger a susses of the save
    before updating the internal akonadi item. So wait for the itemFetchJob
    to finish before emitting the success signal.

diff --git a/incidenceeditor-ng/editoritemmanager.cpp b/incidenceeditor-ng/editoritemmanager.cpp
index bc7827c..9d9c9a2 100644
--- a/incidenceeditor-ng/editoritemmanager.cpp
+++ b/incidenceeditor-ng/editoritemmanager.cpp
@@ -206,8 +206,8 @@ void ItemEditorPrivate::onCreateFinished( int,
 {
   Q_Q( EditorItemManager );
   if ( resultCode == Akonadi::IncidenceChanger::ResultCodeSuccess ) {
+    currentAction = EditorItemManager::Create;
     q->load( item );
-    emit q->itemSaveFinished( EditorItemManager::Create );
     setupMonitor();
   } else {
     kError() << "Creation failed " << errorString;




More information about the commits mailing list