Branch 'roundcubemail-plugins-kolab-format2-horde5' - 2 commits - plugins/tasklist

Thomas Brüderli bruederli at kolabsys.com
Wed Feb 27 12:20:03 CET 2013


 plugins/tasklist/jquery.tagedit.js |   10 +++++-----
 plugins/tasklist/tasklist.js       |    2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 57bc92a195feaa253133196fa517dadc2a8c6bb7
Author: Aleksander Machniak <machniak at kolabsys.com>
Date:   Thu Dec 20 11:11:54 2012 +0100

    Fix tags autocompletion (#1329)

diff --git a/plugins/tasklist/jquery.tagedit.js b/plugins/tasklist/jquery.tagedit.js
index 477f4a4..d70cb32 100755
--- a/plugins/tasklist/jquery.tagedit.js
+++ b/plugins/tasklist/jquery.tagedit.js
@@ -176,9 +176,9 @@
 							var checkAutocomplete = oldValue == true? false : true;
 							// check if the Value ist new
 							var isNewResult = isNew($(this).val(), checkAutocomplete);
-							if(isNewResult[0] === true || (isNewResult[0] === false && typeof isNewResult[1] == 'string')) {
+							if(isNewResult[0] === true || isNewResult[1] != null) {
 
-								if(oldValue == false && typeof isNewResult[1] == 'string') {
+								if(oldValue == false && isNewResult[1] != null) {
 									oldValue = true;
 									id = isNewResult[1];
 								}
@@ -451,7 +451,7 @@
 						}
 					});
 				}
-                
+
 				// If there is an entry for that already in the autocomplete, don't use it (Check could be case sensitive or not)
 				for (var i = 0; i < result.length; i++) {
 					var label = typeof result[i] == 'string' ? result[i] : result[i].label;
@@ -459,7 +459,7 @@
 						label = label.toLowerCase();
 					if (label == compareValue) {
 						isNew = false;
-						autoCompleteId = result[i].id;
+						autoCompleteId = typeof result[i] == 'string' ? i : result[i].id;
 						break;
 					}
 				}


commit 012864b4432980d91acfa988d6c274ab761b607b
Author: Thomas Bruederli <bruederli at kolabsys.com>
Date:   Wed Feb 27 12:16:27 2013 +0100

    Fix selecting tags from autocompletion (#1329)

diff --git a/plugins/tasklist/jquery.tagedit.js b/plugins/tasklist/jquery.tagedit.js
index a9ffd77..477f4a4 100755
--- a/plugins/tasklist/jquery.tagedit.js
+++ b/plugins/tasklist/jquery.tagedit.js
@@ -455,7 +455,7 @@
 				// If there is an entry for that already in the autocomplete, don't use it (Check could be case sensitive or not)
 				for (var i = 0; i < result.length; i++) {
 					var label = typeof result[i] == 'string' ? result[i] : result[i].label;
-					if (options.checkNewEntriesCaseSensitive == true)
+					if (options.checkNewEntriesCaseSensitive == false)
 						label = label.toLowerCase();
 					if (label == compareValue) {
 						isNew = false;
diff --git a/plugins/tasklist/tasklist.js b/plugins/tasklist/tasklist.js
index c0f7f6e..ffb38d6 100644
--- a/plugins/tasklist/tasklist.js
+++ b/plugins/tasklist/tasklist.js
@@ -1046,7 +1046,7 @@ function rcube_tasklist_ui(settings)
                 }
             }
 
-            $('input[name="tags[]"]', rcmail.gui_objects.edittagline).each(function(i,elem){
+            $('input[type="hidden"]', rcmail.gui_objects.edittagline).each(function(i,elem){
                 if (elem.value)
                     me.selected_task.tags.push(elem.value);
             });





More information about the commits mailing list