gunnar: server/php-kolab/Kolab_Server ChangeLog, 1.4.4.1, 1.4.4.2 Kolab_Server.spec, 1.9.4.2, 1.9.4.3 mapping.patch, 1.1.2.1, 1.1.2.2

cvs at kolab.org cvs at kolab.org
Fri Apr 24 19:38:30 CEST 2009


Author: gunnar

Update of /kolabrepository/server/php-kolab/Kolab_Server
In directory doto:/tmp/cvs-serv30736

Modified Files:
      Tag: suc_branch
	ChangeLog Kolab_Server.spec mapping.patch 
Log Message:
Additional fixes for configurable mapping of  LDAP attributes.

Index: ChangeLog
===================================================================
RCS file: /kolabrepository/server/php-kolab/Kolab_Server/ChangeLog,v
retrieving revision 1.4.4.1
retrieving revision 1.4.4.2
diff -u -d -r1.4.4.1 -r1.4.4.2
--- ChangeLog	23 Apr 2009 06:57:24 -0000	1.4.4.1
+++ ChangeLog	24 Apr 2009 17:38:28 -0000	1.4.4.2
@@ -1,3 +1,8 @@
+2009-04-24  Gunnar Wrobel  <p at rdus.de>
+
+	* Kolab_Server.spec: Additional fixes for configurable mapping of
+	LDAP attributes.
+
 2009-04-23  Gunnar Wrobel  <p at rdus.de>
 
 	* Kolab_Server.spec: Support for configurable mapping of LDAP

Index: Kolab_Server.spec
===================================================================
RCS file: /kolabrepository/server/php-kolab/Kolab_Server/Kolab_Server.spec,v
retrieving revision 1.9.4.2
retrieving revision 1.9.4.3
diff -u -d -r1.9.4.2 -r1.9.4.3
--- Kolab_Server.spec	23 Apr 2009 09:15:34 -0000	1.9.4.2
+++ Kolab_Server.spec	24 Apr 2009 17:38:28 -0000	1.9.4.3
@@ -1,7 +1,7 @@
 # Variables
 %define         V_package Kolab_Server
 %define         V_version 0.4.0
-%define         V_release 20090423suc01
+%define         V_release 20090424suc01
 %define         V_sourceurl http://pear.horde.org/get
 
 # Package Information

Index: mapping.patch
===================================================================
RCS file: /kolabrepository/server/php-kolab/Kolab_Server/Attic/mapping.patch,v
retrieving revision 1.1.2.1
retrieving revision 1.1.2.2
diff -u -d -r1.1.2.1 -r1.1.2.2
--- mapping.patch	23 Apr 2009 06:32:38 -0000	1.1.2.1
+++ mapping.patch	24 Apr 2009 17:38:28 -0000	1.1.2.2
@@ -382,7 +382,7 @@
       *
       * @param string $attrs The attributes to return.
 diff --git a/framework/Kolab_Server/lib/Horde/Kolab/Server/ldap.php b/framework/Kolab_Server/lib/Horde/Kolab/Server/ldap.php
-index eee8f52..ddc953f 100644
+index eee8f52..ea73b4f 100644
 --- a/framework/Kolab_Server/lib/Horde/Kolab/Server/ldap.php
 +++ b/framework/Kolab_Server/lib/Horde/Kolab/Server/ldap.php
 @@ -210,6 +210,7 @@ class Horde_Kolab_Server_ldap extends Horde_Kolab_Server {
@@ -393,10 +393,21 @@
              $result = @ldap_read($this->_connection, $dn, '(objectclass=*)', $attrs);
          } else {
              $result = @ldap_read($this->_connection, $dn, '(objectclass=*)');
-@@ -230,6 +231,9 @@ class Horde_Kolab_Server_ldap extends Horde_Kolab_Server {
+@@ -220,7 +221,7 @@ class Horde_Kolab_Server_ldap extends Horde_Kolab_Server {
+         }
+         $entry = $this->_firstEntry($result);
+         if (!$entry) {
+-            ldap_free_result($result);
++            @ldap_free_result($result);
+             return PEAR::raiseError(sprintf(_("LDAP Error: Empty result for: %s."),
+                                             $dn));
+         }
+@@ -229,7 +230,10 @@ class Horde_Kolab_Server_ldap extends Horde_Kolab_Server {
+             return PEAR::raiseError(sprintf(_("LDAP Error: No such dn: %s: %s"),
                                              $dn, $this->_error()));
          }
-         ldap_free_result($result);
+-        ldap_free_result($result);
++        @ldap_free_result($result);
 +
 +        $this->unmapAttributes($object);
 +
@@ -530,7 +541,47 @@
          return $this->_dnForFilter($filter);
      }
  
-@@ -874,7 +944,13 @@ class Horde_Kolab_Server_ldap extends Horde_Kolab_Server {
+@@ -788,8 +858,17 @@ class Horde_Kolab_Server_ldap extends Horde_Kolab_Server {
+     function uidForAttr($attr, $value,
+                        $restrict = KOLAB_SERVER_RESULT_SINGLE)
+     {
+-        $filter = '(&(objectClass=kolabInetOrgPerson)(' . $attr .
+-            '=' . Horde_LDAP::quote($value) . '))';
++        $criteria = array('AND' =>
++                         array(
++                             array('field' => KOLAB_ATTR_OC,
++                                   'op'    => '=',
++                                   'test'  => KOLAB_OC_KOLABINETORGPERSON),
++			     array('field' => $attr,
++				   'op'    => '=',
++				   'test'  => $value),
++                             ),
++        );
++        $filter   = $this->searchQuery($criteria);
+         return $this->_dnForFilter($filter, $restrict);
+     }
+ 
+@@ -806,8 +885,17 @@ class Horde_Kolab_Server_ldap extends Horde_Kolab_Server {
+     function gidForAttr($attr, $value,
+                        $restrict = KOLAB_SERVER_RESULT_SINGLE)
+     {
+-        $filter = '(&(objectClass=kolabGroupOfNames)(' . $attr .
+-            '=' . Horde_LDAP::quote($value) . '))';
++        $criteria = array('AND' =>
++                         array(
++                             array('field' => KOLAB_ATTR_OC,
++                                   'op'    => '=',
++                                   'test'  => KOLAB_OC_KOLABGROUPOFNAMES),
++			     array('field' => $attr,
++				   'op'    => '=',
++				   'test'  => $value),
++                             ),
++        );
++        $filter   = $this->searchQuery($criteria);
+         return $this->_dnForFilter($filter, $restrict);
+     }
+ 
+@@ -874,7 +962,13 @@ class Horde_Kolab_Server_ldap extends Horde_Kolab_Server {
              return $result;
          }
          $vars   = get_class_vars($type);
@@ -545,7 +596,7 @@
          $sort   = $vars['sort_by'];
  
          if (isset($params['sort'])) {
-@@ -993,4 +1069,176 @@ class Horde_Kolab_Server_ldap extends Horde_Kolab_Server {
+@@ -993,4 +1087,176 @@ class Horde_Kolab_Server_ldap extends Horde_Kolab_Server {
          }
      }
  
@@ -696,9 +747,9 @@
 +    {
 +        if (!empty($this->_params['map'])) {
 +            foreach ($this->_params['map'] as $attribute => $map) {
-+                if (in_array($attribute, $keys)) {
-+                    $keys = array_diff($keys, array($attribute));
-+                    $keys[] = $map;
++                $key = array_search($attribute, $keys);
++                if ($key !== false) {
++                    $keys[$key] = $map;
 +                }
 +            }
 +        }





More information about the commits mailing list