From catwiesel at gmx.net Fri Aug 12 09:13:32 2016 From: catwiesel at gmx.net (Matthias Busch) Date: Fri, 12 Aug 2016 09:13:32 +0200 Subject: [Kolab-devel] request to update kolab 16 (centos7) to use php-sabre-dav >= 3.0.9 Message-ID: <0f70b870-5b46-9c07-89f7-4014cd6774b4@gmx.net> hey, I am currently "playing around" with kolab 16 on centos7 - to see what to do when I make the switch from 3.4 on debian7 - and also to help you guys iron out the kinks. I diddnt get far before finding a problem. Granted, it is MY problem, but I would respectfully request that you guys think about upgrading to php-sabre-dav >= 3.0.9 I hope it is a small change to make but it would allow us to use other packages depending on php-sabre-dav like owncloud. manually installing 3.0.9 over whatever 2.x version kolab is bringing will effectively break irony : PHP Fatal error: Call to undefined function Sabre\URI\split() in /usr/share/php/Sabre/HTTP/URLUtil.php on line 85 (when making a calender entry via caldav) thank you for considering. Catwiesel From kolab983 at der-he.de Fri Aug 12 16:57:30 2016 From: kolab983 at der-he.de (hede) Date: Fri, 12 Aug 2016 16:57:30 +0200 Subject: [Kolab-devel] freebusy with 32bit systems Message-ID: <20160812165730.3fd70f44@tbb-phenom.lan> Hi, Freebusy, in particular the "FIND AVAILIBILITY" mask, is nonfunctional with 32 bit architectures. The reason is: in /usr/share/roundcubemail/plugins/calendar/calendar.php -> public function freebusy_times() -> $times[$s] = intval($dt->format($strformat)); -> the results for time in the list from $start till $end gets converted to integer by intval(). (for me it's line 2272) An example for such a date is: "20160824180000". With 64 bit arch this is fine, integers are big enough to hold such values. With 32 bit architectures it gets converted to 2147483647 because an integer variable cannot hold a value of 20160824180000. Thus all dates are wrong in the resulting fbdata/freebusy_data in calendar_ui.js. This results in a timetable full of "unknown" values. Is there a reason to convert the value via intval()? I simply removed it (now adding string values!?) and Freebusy is functional, now. The timetable shows free and busy values. Regards hede (KolabOnArmv7) -------------- next part -------------- A non-text attachment was scrubbed... Name: intval-non32.patch Type: text/x-patch Size: 428 bytes Desc: not available URL: From machniak at kolabsys.com Fri Aug 12 20:06:40 2016 From: machniak at kolabsys.com (Aleksander Machniak) Date: Fri, 12 Aug 2016 20:06:40 +0200 Subject: [Kolab-devel] freebusy with 32bit systems In-Reply-To: <20160812165730.3fd70f44@tbb-phenom.lan> References: <20160812165730.3fd70f44@tbb-phenom.lan> Message-ID: On 08/12/2016 04:57 PM, hede wrote: > Is there a reason to convert the value via intval()? > > I simply removed it (now adding string values!?) and Freebusy is functional, now. The timetable shows free and busy values. I don't see a reason either. What's more, the value is converted back to string in javascript. Could you create task and differential at https://gir.kolab.org? -- Aleksander Machniak Software Developer Kolab Systems AG: http://kolabsys.com PGP: 19359DC1