[Kolab-devel] [issue2686] error in installer install-kolab.sh

[Alain Spineux]

New submission from Alain Spineux <alain.spineux at gmail.com>:

When starting installation I get this message every time.

Received no instructions. Trying to determine required action...
find: paths must precede expression
Usage: find [-H] [-L] [-P] [path...] [expression]

The problem is the use of unprotected wildcard expression in find command 

Here is a patch that solve this problem.


--- install-kolab.sh    2008-04-29 13:02:29.000000000 +0200
+++ install-kolab2.sh   2008-04-30 23:01:25.000000000 +0200
@@ -154,7 +154,7 @@
                        fi
                elif [ -n "$FLAG_SDIST" ]; then
                        SDIST_DIR=$PREFIX/RPM/SDIST
-                       INSTALLER=`find . -name openpkg-*.src.sh -print`
+                       INSTALLER=`find . -name "openpkg-*.src.sh" -print`
                        if [ -z "$INSTALLER" ]; then
                                echo "No source based installer found. Unable to
create a source distribution!"
                                exit 1
@@ -176,7 +176,7 @@
                elif [ -n "$FLAG_BDIST" ]; then
                        PLATTAG=`"$PREFIX/lib/openpkg/shtool" platform
--type=binary`-$TAG
                        BDIST_DIR=$PREFIX/RPM/BDIST
-                       BINARY=`find . -name openpkg-*$PLATTAG.sh -print`
+                       BINARY=`find . -name "openpkg-*$PLATTAG.sh" -print`
                        if [ -z "$BINARY" ]; then
                                echo "No binary installer package found. Unable
to create a binary distribution!"
                                exit 1
@@ -220,8 +220,8 @@
                INSTALL=`pwd`
                echo "Found an OpenPKG environment. Assuming upgrade..."
        else
-               INSTALLER=`find . -name openpkg-*.src.sh -print`
-               BINARY=`find . -name openpkg-*.sh \! -name openpkg-*.src.sh -print`
+               INSTALLER=`find . -name "openpkg-*.src.sh" -print`
+               BINARY=`find . -name "openpkg-*.sh" \! -name "openpkg-*.src.sh"
-print`
                if [ -z "$INSTALLER" ]; then
                        # No install script? Determine if there is a binary script
                        if [ -z "$BINARY" ]; then

-- 
Alain Spineux
aspineux gmail com
May the sources be with you

----------
messages: 14676
nosy: alain.spineux at gmail.com
priority: bug
status: unread
title: error in installer install-kolab.sh
topic: server
___________________________________________________
Kolab issue tracker <kolab-issues at intevation.de>
<https://www.intevation.de/roundup/kolab/issue2686>
___________________________________________________