[Kolab-devel] distributionlists testing

[Gunnar Wrobel]

Hi Thomas,

Thomas Jarosch <thomas.jarosch at intra2net.com> writes:

> Hello Mike,
>
> On Monday, 21. April 2008 13:51:20 Mike Gabriel wrote:
>> --- b/turba/lib/Driver/kolab.php.orig   2008-04-20 18:49:17.000000000 +0000
>> +++ b/turba/lib/Driver/kolab.php        2008-04-20 18:47:49.000000000 +0000
>> @@ -898,7 +898,10 @@
>>                   }
>>                   foreach ($entries as $entry) {
>>                       if (isset($entry[$field])) {
>> -                        $pos = strpos($entry[$field], $value);
>> +                       $pos = false;
>> +                       if ($value) {
>> +                            $pos = strpos($entry[$field], $value);
>> +                       }
>>                           if ($pos === false) {
>>                               continue;
>>                           }
>
> I've fixed the same bug a while ago. Please see upstream bug,
> it does a bit more cleanup: http://bugs.horde.org/ticket/6546

Thanks, commited to CVS.

> Dunno why it's not applied yet.

Last time I did my round of the Horde bugs I had a problem with the
patch. Sadly I was dumb enough not to note exactly what the problem
was. I think it had to do with searching within the Turba API. I'll
have to investigate that later again when I get back to SyncML and so
I commited your patch now.

Cheers,

Gunnar

>
> I'll open another bug since I'm not happy about the stripos() to strpos() 
> change (stripos is PHP5 only). People would be quite upset
> if google would be case sensitive...
>
> Thomas
>
> _______________________________________________
> Kolab-devel mailing list
> Kolab-devel at kolab.org
> https://kolab.org/mailman/listinfo/kolab-devel

-- 
______ http://kdab.com _______________ http://kolab-konsortium.com _

p at rdus Kolab work is funded in part by KDAB and the Kolab Konsortium

____ http://www.pardus.de _________________ http://gunnarwrobel.de _
E-mail : p at rdus.de                                 Dr. Gunnar Wrobel
Tel.   : +49 700 6245 0000                          Bundesstrasse 29
Fax    : +49 721 1513 52322                          D-20146 Hamburg
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   >> Mail at ease - Rent a kolab groupware server at p at rdus <<                 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~