2 commits - plugins/libkolab plugins/tasklist

Thomas Brüderli bruederli at kolabsys.com
Thu Mar 26 16:08:43 CET 2015


 plugins/libkolab/js/audittrail.js                        |   10 ++---
 plugins/tasklist/drivers/kolab/tasklist_kolab_driver.php |   26 +++++++--------
 plugins/tasklist/localization/en_US.inc                  |    5 --
 plugins/tasklist/skins/larry/sprites.png                 |binary
 plugins/tasklist/skins/larry/tasklist.css                |    5 ++
 plugins/tasklist/tasklist.php                            |    7 ++--
 6 files changed, 28 insertions(+), 25 deletions(-)

New commits:
commit f6ad1d2b666aed171f90343afc9b6d58c2d69370
Author: Thomas Bruederli <bruederli at kolabsys.com>
Date:   Thu Mar 26 16:08:39 2015 +0100

    Add icon for history menu item

diff --git a/plugins/tasklist/skins/larry/sprites.png b/plugins/tasklist/skins/larry/sprites.png
index 3552b00..14f8271 100644
Binary files a/plugins/tasklist/skins/larry/sprites.png and b/plugins/tasklist/skins/larry/sprites.png differ
diff --git a/plugins/tasklist/skins/larry/tasklist.css b/plugins/tasklist/skins/larry/tasklist.css
index 79138a6..9a0d716 100644
--- a/plugins/tasklist/skins/larry/tasklist.css
+++ b/plugins/tasklist/skins/larry/tasklist.css
@@ -769,6 +769,7 @@ ul.toolbarmenu li span.icon.taskadd,
 ul.toolbarmenu li span.add,
 ul.toolbarmenu li span.expand,
 ul.toolbarmenu li span.collapse,
+ul.toolbarmenu li span.history,
 ul.toolbarmenu.iconized .selected span.icon {
 	background-image: url(sprites.png);
 }
@@ -789,6 +790,10 @@ ul.toolbarmenu li span.delete {
 	background-position: 0 -1508px;
 }
 
+ul.toolbarmenu li span.history {
+	background-position: 0 -408px;
+}
+
 ul.toolbarmenu.iconized .selected span.icon {
 	background-position: 0 -324px;
 }


commit b26c2a083045437e23cc7200390a03a7908a8a99
Author: Thomas Bruederli <bruederli at kolabsys.com>
Date:   Thu Mar 26 14:57:16 2015 +0100

    Code cleanup + indentation fixes

diff --git a/plugins/libkolab/js/audittrail.js b/plugins/libkolab/js/audittrail.js
index 0fe7bcb..56e0df2 100644
--- a/plugins/libkolab/js/audittrail.js
+++ b/plugins/libkolab/js/audittrail.js
@@ -60,13 +60,13 @@ libkolab_audittrail.object_history_dialog = function(p)
         closeOnEscape: true,
         title: p.title,
         open: function() {
-          $dialog.attr('aria-hidden', 'false');
-          setTimeout(function(){
-            $dialog.parent().find('.ui-button:not(.ui-dialog-titlebar-close)').first().focus();
-          }, 5);
+            $dialog.attr('aria-hidden', 'false');
+            setTimeout(function(){
+                $dialog.parent().find('.ui-dialog-buttonpane .ui-button').first().focus();
+            }, 5);
         },
         close: function() {
-          $dialog.dialog('destroy').attr('aria-hidden', 'true').hide();
+            $dialog.dialog('destroy').attr('aria-hidden', 'true').hide();
         },
         buttons: buttons,
         minWidth: 450,
diff --git a/plugins/tasklist/drivers/kolab/tasklist_kolab_driver.php b/plugins/tasklist/drivers/kolab/tasklist_kolab_driver.php
index 9000d8f..359e242 100644
--- a/plugins/tasklist/drivers/kolab/tasklist_kolab_driver.php
+++ b/plugins/tasklist/drivers/kolab/tasklist_kolab_driver.php
@@ -891,23 +891,23 @@ class tasklist_kolab_driver extends tasklist_driver
      */
     private function _resolve_task_identity($prop)
     {
-      $mailbox = $msguid = null;
+        $mailbox = $msguid = null;
 
-      $this->_parse_id($prop);
-      $uid     = $prop['uid'];
-      $list_id = $prop['list'];
+        $this->_parse_id($prop);
+        $uid     = $prop['uid'];
+        $list_id = $prop['list'];
 
-      if ($folder = $this->get_folder($list_id)) {
-          $mailbox = $folder->get_mailbox_id();
+        if ($folder = $this->get_folder($list_id)) {
+            $mailbox = $folder->get_mailbox_id();
 
-          // get task object from storage in order to get the real object uid an msguid
-          if ($rec = $folder->get_object($uid)) {
-              $msguid = $rec['_msguid'];
-              $uid = $rec['uid'];
-          }
-      }
+            // get task object from storage in order to get the real object uid an msguid
+            if ($rec = $folder->get_object($uid)) {
+                $msguid = $rec['_msguid'];
+                $uid = $rec['uid'];
+            }
+        }
 
-      return array($uid, $mailbox, $msguid);
+        return array($uid, $mailbox, $msguid);
     }
 
 
diff --git a/plugins/tasklist/localization/en_US.inc b/plugins/tasklist/localization/en_US.inc
index 8dc2929..0bf8894 100644
--- a/plugins/tasklist/localization/en_US.inc
+++ b/plugins/tasklist/localization/en_US.inc
@@ -51,8 +51,6 @@ $labels['assignedto'] = 'Assigned to';
 $labels['created'] = 'Created';
 $labels['changed'] = 'Last Modified';
 $labels['taskoptions'] = 'Options';
-$labels['taskhistory'] = 'History';
-$labels['compare'] = 'Compare';
 
 $labels['all'] = 'All';
 $labels['flagged'] = 'Flagged';
@@ -155,16 +153,15 @@ $labels['itipcancelmailbody'] = "*\$title*\n\nDue: \$date\n\nAssignees: \$attend
 $labels['saveintasklist'] = 'save in ';
 
 // history dialog
+$labels['taskhistory'] = 'History';
 $labels['objectchangelog'] = 'Change History';
 $labels['objectdiff'] = 'Changes from $rev1 to $rev2';
-
 $labels['actionappend'] = 'Saved';
 $labels['actionmove'] = 'Moved';
 $labels['actiondelete'] = 'Deleted';
 $labels['compare'] = 'Compare';
 $labels['showrevision'] = 'Show this version';
 $labels['restore'] = 'Restore this version';
-
 $labels['objectnotfound'] = 'Failed to load task data';
 $labels['objectchangelognotavailable'] = 'Change history is not available for this task';
 $labels['objectdiffnotavailable'] = 'No comparison possible for the selected revisions';
diff --git a/plugins/tasklist/tasklist.php b/plugins/tasklist/tasklist.php
index 869a192..c83d763 100644
--- a/plugins/tasklist/tasklist.php
+++ b/plugins/tasklist/tasklist.php
@@ -393,9 +393,10 @@ class tasklist extends rcube_plugin
                 $dtformat = $this->rc->config->get('date_format') . ' ' . $this->rc->config->get('time_format');
                 array_walk($data, function(&$change) use ($lib, $dtformat) {
                   if ($change['date']) {
-                    $dt = $lib->adjust_timezone($change['date']);
-                    if ($dt instanceof DateTime)
-                      $change['date'] = $this->rc->format_date($dt, $dtformat, false);
+                      $dt = $lib->adjust_timezone($change['date']);
+                      if ($dt instanceof DateTime) {
+                          $change['date'] = $this->rc->format_date($dt, $dtformat, false);
+                      }
                   }
                 });
                 $this->rc->output->command('plugin.task_render_changelog', $data);




More information about the commits mailing list