Changes to 'dev/listfilter'
Christian Mollekopf
mollekopf at kolabsys.com
Sun Jun 22 13:57:26 CEST 2014
New branch 'dev/listfilter' available with the following commits:
commit 28fdbbbed646b997899ce3a1ecec92f9158ec206
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Sun Jun 22 13:57:13 2014 +0200
ETMCalendar: Use listfilter to hide no-enabled collections
commit 7a7656abe535e596492c249e1791dc1eb1004c17
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Fri Jun 20 18:17:18 2014 +0200
ETM: cleanup
commit 5f46d71d518ccbcaecfabaa74308b6486e0eb59c
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Fri Jun 20 17:56:43 2014 +0200
ETM: Only remove collections that are no longer monitored if they shouldn't be part of the model anymore.
commit ba6febcbb64e5b82fcdfd4dc618c5aafa48f47fd
Author: John Layt <jlayt at kde.org>
Date: Thu Jun 19 15:38:33 2014 +0100
Update file categories
Update th file name category tags to match the Plan2 categories.
commit 290f2c8ddf8857802a7eb62931c6631aaf9d80be
Author: John Layt <jlayt at kde.org>
Date: Thu Jun 19 14:51:10 2014 +0100
Change test order
Do teh region test first.
commit e87ced7c26d21a142fd210bd9ac588449190d15a
Author: John Layt <jlayt at kde.org>
Date: Thu Jun 19 14:49:16 2014 +0100
Update holiday files to new category format
Add categories to all the holiday data files. Where uncertain of a
category I have used civil by default. Please correct as appropriate.
commit 607d1e3e3c79cf439fc4f669e7832b57f3a0b5d3
Author: John Layt <jlayt at kde.org>
Date: Wed Jun 18 19:29:06 2014 +0100
Regenerate Bison/Flex parser for Plan2 format
Regenerate teh parser using teh updated format and the ltest versions
of Bison and Flex.
commit febe5764ab03239651de4f150c486ae7d5f6a05a
Author: John Layt <jlayt at kde.org>
Date: Wed Jun 18 22:28:05 2014 +0100
Fix Plan2 format parser bugs
Fix a couple of bugs that the more recent Bison doesn't tolerate.
commit 22eae7b5d7bb0879c34cfc71dc40e5afa1168edf
Author: John Layt <jlayt at kde.org>
Date: Wed Jun 18 18:27:12 2014 +0100
Add Category support to the Plan2 format
Add support for assigning categories to a holiday. A holiday must have
one or more categories.
commit 1ba8d937e80dfe434cf65617ebc441a20ec4fbda
Author: John Layt <jlayt at kde.org>
Date: Wed Jun 18 01:20:16 2014 +0100
Remove color support from Plan2 format
Remove the color options from the Plan2 format as it is mostly unused
except for "weekend", which will be replaced by proper category support.
commit 0b3ca84214397c31ca48e54281bb400021315c52
Author: John Layt <jlayt at kde.org>
Date: Wed Jun 18 00:32:23 2014 +0100
Remove small keyword from Plan2 format
Remove small as it is unused in KHolidays. The parser code will be
regenerated once all format changes are completed.
commit f6bdfa61106cb559bfbcfdc9ee2bfb97d996c081
Author: John Layt <jlayt at kde.org>
Date: Wed Jun 18 00:09:02 2014 +0100
Delete old Plan1 format support
The old Plan1 format support has long been dropped and was only being
kept for historical reference purposes. Delete to prevent any confusion.
commit f1ee0b3d5a373edca4f2dd47676b2bbc97ed3f95
Author: Dan Vrátil <dvratil at redhat.com>
Date: Fri Jun 20 16:20:42 2014 +0200
StandardActionManager: New subcollection of a virtual collection should be virtual too
When a virtual collection has a special virtual mime type, then newly a
created subcollection should be virtual too.
commit 80053a66e0728dc568af432b4d9529ed59e4c7f2
Author: Dan Vrátil <dvratil at redhat.com>
Date: Thu Jun 19 19:59:52 2014 +0200
Implement client-side support for Virtual References in ItemFetchJob
When fetchVirtualReferences is enabled in ItemFetchScope, the resulting Items
will have their virtualReferences() populated by list of collections that they
are linked to.
commit 679de2cde56bf2b73af25c3b4c4249a3e22318af
Author: Dan Vrátil <dvratil at redhat.com>
Date: Thu Jun 19 16:52:09 2014 +0200
CollectionPathResolver: add API to specify collection to resolve relatively to
Top-level collections don't have to have a unique name (for instance one can have
a calendar and a mail account both called 'Work'), but CPR is too stupid for that
and will try to resolve the path from the first matching collection it finds,
which can lead to false or wrong results.
The new constructor allows specifying a collection that the CPR should resolve the
path relatively to. This can be used by resources for example, which can set their
root collection (which they usually now) and then resolve relatively to it.
commit e2a49f29ca986248150c37ad3069ee4c3ed5eae3
Author: Dan Vrátil <dvratil at redhat.com>
Date: Thu Jun 19 15:58:52 2014 +0200
CollectionPathResolver: always return invalid collection ID if the job fails
commit 4c7ce7009f5655b861c211ddc6bfdfbb7185034c
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Thu Jun 19 10:58:55 2014 +0200
ETMPopulationTest: Fix after recent change.
We cannot use isCollectionTreeFetched anymore for that.
commit d2998f1719e48d8af23f3e729b3132998932618b
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Thu Jun 19 10:02:08 2014 +0200
ETM: Never reset the collectionTreeFetched state.
This state is only there to evaluate if the initial collection tree
fetch is complete (it's mostly used to restore the view state).
Later changes to the monitored collections should not reset that state.
commit c6855b57421520370fe6a8bb91eeca6f6fb40ab7
Author: Montel Laurent <montel at kde.org>
Date: Thu Jun 19 08:04:51 2014 +0200
Add SORT-AS argument
commit 52f06f5bd9080df43178b1a882bf3c20857d6089
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Wed Jun 18 09:55:41 2014 +0200
Collection: setShouldList for symmetry with shouldList.
commit 64d24a6b50646b1f043ec8a5648dd20b520c0987
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Thu Jun 12 00:51:14 2014 +0200
EntityTreeModelTest: Cleanup.
The full test passes now.
commit d565f258cfb7e6cb13ce5062feaaea5f393b13d0
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Thu Jun 12 00:40:42 2014 +0200
ETM: Removed unused code
commit e8017b754dfb02a8f4772ba0f81cb7b2b403c60e
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Thu Jun 12 00:40:05 2014 +0200
ETM: The corresponding collection could have been removed while a fetch job is in progress.
commit 8ced3d05806c9c0af9e6fd55493140fe492e1421
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Wed Jun 11 17:53:10 2014 +0200
ETMPopulationTest: Fixed waiting for signals with isFullyPopulated.
commit 4f694f0aa21baf3e7417066858e3c2c3999cc10d
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Wed Jun 11 17:51:19 2014 +0200
ETM: Provide isFullyPopulated to include population of collections and items.
This returns only true once all collections and items have been fetched.
This is primarily important for tests to ensure no further signals are emitted
by the initial population.
commit bb4b1182b6aeaeb2efde0cc3739bfff1d225b110
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Wed Jun 11 17:50:01 2014 +0200
ETM: Split fetchJobDone + correctly emit dataChanged signals.
Split fetchJobDone into separate versions for Item/Collection fetch jobs.
Having a combined slot was confusing since the codepaths were separate anyways.
Additionally dataChanged was emitted in the wrong slot, as it is required
to notify about the changed fetch state, so it has to be emitted after the
itemFetchJob.
commit 437f187d83253d1fc15c8afd4c67bd592a335df0
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Wed Jun 11 16:39:08 2014 +0200
ETM: removed unused code.
commit 1ebaaf16766ea005f02e5e6ca12453f66682bc27
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Wed Jun 11 16:12:38 2014 +0200
ETM: Don't use reinterpret_cast to cast void* to class.
static_cast is what we want, reinterpret_cast in the best case does the same
and in the worst case breaks something.
commit eb5dd93a5ef3f960fa97b85a712ec32ff93e37c4
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Wed Jun 11 14:28:49 2014 +0200
ETMPopulationTest: Test signals while referencing.
commit db636ff4b5ed040698cb4103d019454a01321bf2
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Wed Jun 11 14:26:23 2014 +0200
ETM: only emit rowsInserted when we actually insert a new row.
And otherwise emit the signal individually for the subrows
ETM: use the correct parent for inserted ancestors.
commit e601bd33309d625a2b8c45c7a351abee69545f93
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Tue Jun 10 13:32:58 2014 +0200
ETM: Removed FirstList hack.
This was never working with a mimetype filter because the toplevel collections
would never match the filter and the initial fetch was thus always empty.
It used to be fixed automatically because the second fetch used to be
a recursive fetch from root anyways.
Simply listing all collections right away should be fast enough, and removing
the hack allowed me to fold a bunch of codepaths into one.
commit d949fdaaa71d92112bb310ebbbde017718c9f345
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Tue Jun 10 01:32:46 2014 +0200
ETMPopulationTest: displayfilter test
commit 524fbc133babf377c3fcd83660e09702244278fe
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Mon Jun 9 23:27:57 2014 +0200
ETM: Support for referencing collections.
commit 58af6d2ca8194ea051a36c61af23cb827d3f3fb0
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Mon Jun 9 19:09:34 2014 +0200
ETM: Monitoring specific collections only.
commit f0ab5e2bbf5ffbdb20a70fbbf458cb6cd2b84647
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Mon Jun 9 19:02:13 2014 +0200
Referenced support for CollectionModifyJob & Collection
Including CollectionJobTest.
commit e6eb1439a62616828cdbf2bb8e8566494abcd33a
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Sat Jun 7 00:05:51 2014 +0200
ETM-Test: Only trigger the event loop but don't wait any longer.
commit 82c02b88dfb08ee9f81a72bc21988991864b60fe
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Sat Jun 7 00:04:53 2014 +0200
ETM: Only keep collection if it has subcollections.
Otherwise a disabled collection that contains items is never removed.
commit 91359e2865e1949b66c8e780e9c2ceec75fd83d7
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Wed Jun 11 14:27:21 2014 +0200
Collection: Only set enabledChanged if it has changed.
The code before would reset enabledChanged to false should we i.e. call
setEnabled(true) twice
commit 4afb562298b0b3fca9b6603ba817adbed0c7bf15
Author: Dan Vrátil <dvratil at redhat.com>
Date: Mon Jun 16 11:00:56 2014 +0200
Exclude mailtransport-messagequeuejobtest from default test suite
messagequeuejobtest requires akonadi_maildispatcher_agent from
kdepim-runtime, which is not available on Jenkins when kdepimlibs
is being built.
To enable the test locally, run cmake with
-DKDEPIMLIBS_RUN_KDEPIMRUNTIME_ISOLATED_TESTS=TRUE
commit f266f633450750b4035fc517369bfafadcd8216f
Author: Dan Vrátil <dvratil at redhat.com>
Date: Mon Jun 16 10:28:45 2014 +0200
MonitorTest: Toggle resource offline after resolving the test collection
commit 88330d39263dfdef23682fa13691eab8644ee3bb
Author: Dan Vrátil <dvratil at redhat.com>
Date: Wed Jun 11 19:48:18 2014 +0200
Run akonadi/kmime unit-tests only when KDEPIMLIBS_RUN_KDEPIMRUNTIME_ISOLATED_TESTS is defined
These tests depend on the akonadi_maildir_resource, which is provided by
kdepim-runtime, so they cannot be run in Jenkins, where kdepim-runtime is
not available during kdepimlibs compilation, as that would create circular
dependencies.
Also the KMime tests are quite broken (since a long time) and I don't really
understand how to fix them.
commit 7ae77a362833a9be11f18e8c972ee778d612ac42
Author: Dan Vrátil <dvratil at redhat.com>
Date: Wed Jun 11 19:45:27 2014 +0200
LocalFoldersTest: reset the defaultResourceId config value
From previous testcases, the defaultResourceId is set to akonadi_knut_resource,
but this test-case expects maildir.
commit c52e373b69955d615539ed97659e0435ef44eb84
Author: Dan Vrátil <dvratil at redhat.com>
Date: Wed Jun 11 19:44:28 2014 +0200
LocalFoldersTest: include Akonadi instance name in org.kde.pim service name
commit 0600ec79162917578805b4450ec2063b3c6505dd
Author: Dan Vrátil <dvratil at redhat.com>
Date: Wed Jun 11 19:11:24 2014 +0200
SpecialMailCollectionsTesting: write settings directly to file
SMCT and SMC use different instances of KConfigSkeleton, so just storing
the configuration in variable is not enough, we need to actually write it
to the config file, to make sure that SMC picks up the changes.
commit 87956ad61dbd8a1987dda305ce841f9497207bee
Author: Dan Vrátil <dvratil at redhat.com>
Date: Wed Jun 11 18:00:01 2014 +0200
Comparing two invalid Entities should always return true
Every time a new invalid Entity is constructed, it's assigned a decremental
negative number. Since two invalid Entities always have different negative
numbers, simple Item() == Item() comparision would return false, as internally
only IDs were compared. From logical point of view it makes however sense
for invalid Entities to be considered equal.
As of now, operator==() and operator!=() takes entity validity in consideration,
so Item() == Item() is always true and Item() != Item() is always false.
commit 0258b092edae4117475ddda8718c6997c0d0d496
Author: Dan Vrátil <dvratil at redhat.com>
Date: Wed Jun 11 16:04:31 2014 +0200
Run akonadi/kmime isolated test against SQLite, not MySQL
There's really no reason to start MySQL for a unit-test if we can use
SQLite now just fine.
commit 0cc77a6584776db286303296151ba983f73e9093
Author: Dan Vrátil <dvratil at redhat.com>
Date: Wed Jun 11 15:57:06 2014 +0200
Disable itembenchmarktest for now
Benchmarks are cool, but only if you have anything to compare the results
again, which we don't. Any major performance regressions will be spotted
by devs anyway, so there's little point running the benchmark, which takes
over 40 seconds, on Jenkins.
Developers can run it locally if they wish.
commit 6cecb0b544eb841de31dbded6bc408824da01672
Author: Dan Vrátil <dvratil at redhat.com>
Date: Wed Jun 11 15:41:55 2014 +0200
Fix MonitorTest's metatype issues and adapt to changes in signal order
This test was broken for a long time due to Qt not supporting qRegisterMetaType
for typedefs correctly. This has been fixed in Qt 4.7, so we can use the test now.
Slight modifications to the test were needed: the order of collectionStatisticsChanged
notifications is reversed in case of item move, and collection(Un)Subscribed signals are
now preceded by collectionChanged() signal.
commit a785c835701f4cbcfabb1e60a5b9b0745cf295a1
Author: Montel Laurent <montel at kde.org>
Date: Wed Jun 11 09:26:19 2014 +0200
Pedantic
commit 3914436f7a7ccf6e2102441a023019b86d70fea8
Author: Dan Vrátil <dvratil at redhat.com>
Date: Tue Jun 10 14:41:43 2014 +0200
Fix ItemDeleteTest
Take into account new rules for Tag creation (tag with RID can only
be created by a resource).
commit 7228a15d3be7da85f5c422d1419ed2702a735e75
Merge: 27dca58 fa4cc7f
Author: Dan Vrátil <dvratil at redhat.com>
Date: Mon Jun 9 11:47:36 2014 +0200
Merge branch 'KDE/4.13'
commit fa4cc7f9a3deaf15dba95f4ea93da7a430327bfb
Author: Dan Vrátil <dvratil at redhat.com>
Date: Mon Jun 9 11:46:37 2014 +0200
Fix ResourceSchedulerTest
The AttributesSync task type now has a higher priority, reflect it in the test.
commit 27dca585f2bd90acd8e6843dba0b13691bcef00f
Merge: 9b76f58 dc97df0
Author: Montel Laurent <montel at kde.org>
Date: Mon Jun 9 11:16:33 2014 +0200
Merge remote-tracking branch 'origin/KDE/4.13'
Conflicts:
akonadi/resourcescheduler_p.h
commit dc97df054b2eaae2556eae56d6b01f38c00b3a2a
Author: David Faure <faure at kde.org>
Date: Sat Jun 7 10:47:22 2014 +0200
Speed up opening the folder properties dialog in kmail.
An IMAP mail check schedules a large number of tasks.
Tasks that the user is waiting for, such as ItemFetch (reading one mail)
or SyncCollectionAttributes (as called by the folder properties dialog)
should have priority over that.
There might be more types of tasks that the user could potentially be waiting for.
Maybe we could even blacklist instead of whitelist, i.e. put folder-sync tasks
in a low-prio queue, while the default queue would be above it. Not sure.
BUG: 314876 325756
REVIEW: 118602
commit d6176fe844e5f2ac44ef29df3a74aea9808a9149
Author: Sergio Martins <iamsergio at gmail.com>
Date: Sat Jun 7 18:48:39 2014 +0100
Relax this organizer check when creating a new event.
It can happen during normal usage, like when copy-pasting an event.
Not sure if we should allow copy-pasting such events though, and if we
do, should we make us the organizer ?
CCMAIL: dfaure at kde.org
commit 9b76f58b2aabc6e76bd78f2e1e297b2b0c4af24f
Merge: f379b20 0743a0e
Author: David Jarvie <djarvie at kde.org>
Date: Thu Jun 5 23:15:30 2014 +0100
Merge commit '0743a0ead6d43517a2ef89209c8d4ebd648a003e'
commit 0743a0ead6d43517a2ef89209c8d4ebd648a003e
Author: David Jarvie <djarvie at kde.org>
Date: Thu Jun 5 23:12:42 2014 +0100
Add tests at time zone shift boundary
commit f379b20e19c80f5b2d23b745d70b1abcdbead108
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Thu Jun 5 17:54:41 2014 +0200
Cleanup of support for enabled state.
Includes comments by David Jarvie, thanks!
REVIEW: 118525
commit 1a9245e7594dda1b96d2e67d8d7fc551bd416957
Author: David Jarvie <djarvie at kde.org>
Date: Thu Jun 5 01:33:48 2014 +0100
Fix macros setting up date/times
commit 86b19a283601e88e12be4fbb559f51cb3d06473b
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Wed Jun 4 21:23:06 2014 +0200
Support for enabled state and local preference.
This patch replaces local subscriptions with the enabled state + local preferences.
commit e9ca0e7389e30c2afe658d869bb833cf363ab0c7
Merge: ac7cd65 0a23465
Author: Sandro Knauà <knauss at kolabsys.com>
Date: Wed Jun 4 10:03:10 2014 +0200
Merge remote-tracking branch 'origin/KDE/4.13'
commit 0a23465bc5ea2ba74e96824670c71dc93cf80e32
Author: Sandro Knauà <knauss at kolabsys.com>
Date: Sun Jun 1 17:42:43 2014 +0200
Use credentials in the "Edit Host" window to query LDAP Server.
If the server needs authentification to connect, the "Query Server"
to get the namingcontexts should use the credentials.
BUG: 335651
FIXED-IN: 4.13.2
FEATURE: 118496
commit e89eb5f96dfd891312054a4e4b377f9a04e36edb
Author: Sandro Knauà <knauss at kolabsys.com>
Date: Mon Jun 2 14:11:40 2014 +0200
Anonymous login means no user and password are used
commit ac7cd652903aec90985b49a24a43c4b026978364
Author: Sandro Knauà <knauss at kolabsys.com>
Date: Tue Jun 3 17:17:57 2014 +0200
Fix 287242 - Empty error window when querying an ldap server
Showing a standard error text, when no one is returned from job.
BUG: 287242
FIXED-IN: 4.14
REVIEW: 118502
commit 1c5aba09c21fd014f1f369ca7d1fb9f67b538cbd
Author: l10n daemon script <scripty at kde.org>
Date: Wed Jun 4 07:09:39 2014 +0000
SVN_SILENT made messages (.desktop file)
commit 04ee80546ebdbdb0a4dd044b056860e7992e90c8
Merge: 2259289 2593567
Author: Montel Laurent <montel at kde.org>
Date: Wed Jun 4 07:20:44 2014 +0200
Merge remote-tracking branch 'origin/KDE/4.13'
Conflicts:
CMakeLists.txt
commit 259356714b5df5ff1f5f072845dcd951f7f6bda4
Author: Montel Laurent <montel at kde.org>
Date: Wed Jun 4 07:15:59 2014 +0200
4.13.2
commit 2259289df502b086b1b9aea7cb06c650a66108cb
Author: l10n daemon script <scripty at kde.org>
Date: Wed Jun 4 04:18:33 2014 +0000
SVN_SILENT made messages (.desktop file)
commit 6fa09c5e81488ec1efc56f4409615995bbe6d489
Author: Montel Laurent <montel at kde.org>
Date: Wed Jun 4 00:11:11 2014 +0200
Add support for vcard4
commit 2c99f13c6766a9b3d8b004ba01193c8ef0da4adb
Author: Montel Laurent <montel at kde.org>
Date: Mon Jun 2 22:59:56 2014 +0200
Continue to adapt vcard4 support
commit 3947fbe8d6a91083419029fed782a03a28c480c7
Author: Montel Laurent <montel at kde.org>
Date: Mon Jun 2 09:44:04 2014 +0200
Export to vcard4.0
commit 1aa95b37ea2a1793932d4884a24f184a94242c5c
Author: Montel Laurent <montel at kde.org>
Date: Mon Jun 2 09:35:51 2014 +0200
Mailer and Name is not in vcard4.0
commit e86f04330278b6edde3854a4f804a85e1572dac5
Author: Montel Laurent <montel at kde.org>
Date: Mon Jun 2 09:14:02 2014 +0200
Start to merge vcard4 support
commit d04fcaa161c2d96ede53f1c701db7a3d5fa2b7c4
Author: Sandro Knauà <knauss at kolabsys.com>
Date: Thu May 29 20:31:53 2014 +0200
Adding ability to subclass Fakeserver.
For subclasses it is needed to have control over the received and
expeced values of transmissions.
REVIEW: 118408
commit d9f239bf8d0bbcfac3f0a5de4e48642617812565
Author: Maximiliano Curia <maxy at debian.org>
Date: Wed May 28 12:24:08 2014 +0200
Build and install akonaditest and Knut even when kdepimlibs are built without tests
Makes it possible to still run tests of other components (runtime) that require
akonaditest and Knut.
BUG: 331529
FIXED-IN: 4.14
commit 8fcac77c48c85d8e21dd2a719168684e3bd71f3e
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Tue May 27 16:33:33 2014 +0200
CollectionFetchJob: ensure result() is the last signal emitted.
If we simply use delayedEmitResult() instead of emitResult() it is already
ensured that all collections are emitted before result, the whole flushing
not necessary. This also fixes the recursive fetch, where the collections
were not emitted before result, which is IMO a bug.
I added the required tests to ensure the job behaves like it should.
REVIEW: 118329
commit d9fd3645b4cc0cd4ba1000721f4dfd9057bb78da
Author: Dan Vrátil <dvratil at redhat.com>
Date: Mon May 26 18:05:57 2014 +0200
Implement support for direct payload streaming to Create and Modify jobs
ItemCreateJob and ItemModifyJob now handle STREAM continuation response and can
write part payload data directly into the file received in the server response.
commit 1ff4b62b2a7c07780dca973cb36e82b1cdda64a8
Author: Dan Vrátil <dvratil at redhat.com>
Date: Fri May 23 16:44:11 2014 +0200
Fix handling of tags in ItemCreateJob
Requires fixed server.
commit cecdd2b4edc9687d2b4f31f54b34a79eb4136ad8
Merge: beeb09a d40b41c
Author: Dan Vrátil <dvratil at redhat.com>
Date: Mon May 19 10:09:34 2014 +0200
Merge branch 'KDE/4.13'
commit d40b41c3287574d98bed7f4b5585b6c7511147cf
Merge: a05654d 366c6b2
Author: Dan Vrátil <dvratil at redhat.com>
Date: Mon May 19 10:08:53 2014 +0200
Merge branch 'KDE/4.13' of git://anongit.kde.org/kdepimlibs into KDE/4.13
commit a05654dfaff5d32ad89bd69e8aad38ffa3248db3
Author: Dan Vrátil <dvratil at redhat.com>
Date: Mon May 19 10:08:27 2014 +0200
Add explicit to Tag jobs ctors
commit 366c6b2697793272e581bfbf7bc05cee989ad017
Author: Lasse Liehu <lasse.liehu at gmail.com>
Date: Sun May 18 14:47:36 2014 +0300
Fix typo in Finnish holidays
BUG: 334975
FIXED-IN: 4.13.2
commit beeb09ae439c81004a55f57e82792803eda45847
Merge: b33320c 2c806db
Author: Dan Vrátil <dvratil at redhat.com>
Date: Fri May 16 16:48:05 2014 +0200
Merge branch 'KDE/4.13'
commit 2c806dbfd52b4d1ce2974ef69528ca0c28ba62de
Author: Dan Vrátil <dvratil at redhat.com>
Date: Fri May 16 16:47:42 2014 +0200
Add documentation to TagFetchJob
commit b33320ca6b66f814c366fa3b0b90cb5901661b69
Author: Jonathan Marten <jjm at keelhaul.me.uk>
Date: Tue May 13 11:24:41 2014 +0100
Fix tag data not being updated by a TagModifyJob
TagModelPrivate::monitoredTagChanged() is called as expected,
but in the case where the tag is not being reparented (the
usual case), the new tag is not copied back into the parent's
mChildTags list. This means that TagModel::data() still accesses
the old tag via tagForIndex() and hence does not reflect the
change.
REVIEW:118103
commit 0aeb4926e36607a15dc80e79e051542c24041157
Merge: e54f901 61cfe3b
Author: Sandro Knauà <mail at sandroknauss.de>
Date: Mon May 12 21:23:11 2014 +0200
Merge remote-tracking branch 'origin/KDE/4.13'
commit 61cfe3bcfd5541e071649469bb111aca71a7ebf7
Author: Sandro Knauà <mail at sandroknauss.de>
Date: Mon May 12 16:54:31 2014 +0200
Added tests for ANNOTATEMORE mode.
REVIEW: 118100
commit 2ed9d5f4074e30a8fc44776c5e2d7fd12064e5c5
Author: Sandro Knauà <mail at sandroknauss.de>
Date: Mon May 12 16:39:50 2014 +0200
Make GETMETADATA RFC 5464 compatiple.
Adding tests to make sure that GETMETADATA is send in the correct form
that is requested by RFC 5464.
commit 4a85c6bd2275037dfa626ee34a1fd75d2fa6eb39
Author: l10n daemon script <scripty at kde.org>
Date: Mon May 12 07:24:32 2014 +0000
SVN_SILENT made messages (.desktop file)
commit e54f9018f9f6bc903c5191e66bf5d4ba806b7684
Author: l10n daemon script <scripty at kde.org>
Date: Mon May 12 04:33:44 2014 +0000
SVN_SILENT made messages (.desktop file)
commit 19f1bfc6030bbcde96007aa0e4e60e07db30670c
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Thu May 8 11:54:21 2014 +0200
ItemSync: Use serverside merging.
Instead of fetching all local items to check for changes, to then write modified items
back to the server, we use the serverside merging instead.
Additionally this patch allows to merge by gid instead of rid, simply by setting
the gid additionally to the rid.
By using the serverside merging, the code could be simplified and we only need
to fetch the local items anymore to detect removed items when doing a full
listing.
This patch renders ItemSync::updateItem useless, but that should be ok as
I couldn't find a single subclass of ItemSync, and I really don't
expect there to be one out there.
REVIEW: 117854
commit 05aed125e9224416e61fbfa63b13ef84a34dc6bd
Merge: 680348b c7f2ab2
Author: Montel Laurent <montel at kde.org>
Date: Thu May 8 10:43:11 2014 +0200
Merge remote-tracking branch 'origin/KDE/4.13'
commit c7f2ab22f7c61155501b03ac62745d34b4900bbe
Author: Guy Maurel <guy.maurel at kde.org>
Date: Thu May 8 09:26:48 2014 +0200
Coding Style
REVIEWS: 117219 117227 117228 117241 117243
commit 680348b20051850e490d2f73c27fb16260c87012
Author: Montel Laurent <montel at kde.org>
Date: Wed May 7 09:58:31 2014 +0200
Revert "Fix cmakelists.txt"
This reverts commit c0a80fd0fe5149f95ee7c35b20bf6e5b7c729431.
commit c0a80fd0fe5149f95ee7c35b20bf6e5b7c729431
Author: Montel Laurent <montel at kde.org>
Date: Wed May 7 09:55:29 2014 +0200
Fix cmakelists.txt
commit 4c192554d582fc849f5d028928e50259c0622496
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Wed May 7 00:17:22 2014 +0200
TagCreateJob/TagModifyJob: tag type support + proper REMOTEID key + only finish job once complete.
REVIEW: 117771
commit 782cafb7dca37898bd72a4a8a61f6b5d9dad1a94
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Tue May 6 16:02:23 2014 +0200
ItemCreateJob: Explicit merge API + support for incremental changes + tag support.
* Merge only by certain identifiers.
* Only merge certain parts of an item (such as flags)
* allow to pass tags with a created/merged item.
commit 5a4a57e23519fb61493f08c51dbf416696e7ef2a
Author: Sandro Knauà <knauss at kolabsys.com>
Date: Tue May 6 10:39:50 2014 +0200
Bump Patch version for the changes in kcalcore/attendee
commit f6cc20c3abc52cf514766e2efbac3b492415c2fc
Merge: 3fc5597 86674a0
Author: Montel Laurent <montel at kde.org>
Date: Mon May 5 13:24:58 2014 +0200
Merge remote-tracking branch 'origin/KDE/4.13'
Conflicts:
CMakeLists.txt
commit 86674a0ce0507fda563349fdf570b7dbf0e3eb3e
Author: Montel Laurent <montel at kde.org>
Date: Mon May 5 13:21:24 2014 +0200
4.13.1
commit 475fd4a85eae873661465f23e8b8be1b4b630e84
Author: Patrick Spendrin <ps_ml at gmx.de>
Date: Mon May 5 11:11:28 2014 +0200
fix errors gcc ignores
commit 3fc5597f8a8c67077df7c072b300332ef0e24e34
Author: Dan Vrátil <dvratil at redhat.com>
Date: Fri May 2 16:42:50 2014 +0200
Update itemappendtest to reflect changes in Akonadi
Akonadi can now tell the difference between empty payload and
no payload, so once Item::setPayload() is called, the item is
considered to have a payload, even if it's empty.
commit 5a6f60531ede38c248514e113d3f83a02dee84ec
Author: Sandro Knauà <knauss at kolabsys.com>
Date: Tue Apr 29 17:47:59 2014 +0200
Handling attendee cutype read&write ical
REVIEW: 117898
commit 53746294924083e881d87eac53466525ebbf1192
Author: Sandro Knauà <mail at sandroknauss.de>
Date: Wed Apr 30 18:15:33 2014 +0200
Added @since header to kcalcore/attendee.h
commit af4c32525148d724c605d312537e3cb2d370ad94
Author: Sandro Knauà <knauss at kolabsys.com>
Date: Tue Apr 29 16:35:48 2014 +0200
Added handling for cutype of an Attendee
REVIEW: 117875
commit a905c899ee83dc34e35529a79ce7279308089364
Author: Dan Vrátil <dvratil at redhat.com>
Date: Tue Apr 29 10:17:12 2014 +0200
ItemDeleteJob: add missing implementation of tag-scope delete
Looks like I added the ItemDeleteJob(Tag&) constructor to header but forgot
to actually implement it.
commit 9b47419ccbf40fafc189f9f6bbf1e49d90571915
Author: Christophe Giboudeaux <cgiboudeaux at gmx.com>
Date: Sun Apr 27 11:12:16 2014 +0200
Update the Greek holidays file
BUG: 312840
FIXED-IN: 4.13.1
commit 0c4096712ed58be2c424419a3591ec1e624e502b
Merge: 0df0950 ddc8e05
Author: Montel Laurent <montel at kde.org>
Date: Sun Apr 27 08:02:54 2014 +0200
Merge remote-tracking branch 'origin/KDE/4.13'
commit ddc8e056750d071ad68855e35e0c752a08bf2139
Author: Montel Laurent <montel at kde.org>
Date: Sun Apr 27 08:01:56 2014 +0200
Fix Bug 333922 - can't use tag with special symbol
FIXED-IN: 4.13.1
BUG: 333922
commit 0df0950691ab2f8224767119dfdc9e1566e2f5e4
Author: Dan Vrátil <dvratil at redhat.com>
Date: Thu Apr 24 16:08:58 2014 +0200
Implement support for MERGE command in ItemCreateJob
By setting ItemCreateJob::setMergeIfExists to true, the server job will
use MERGE instead of AK-APPEND command. Server will try to merge the
new item with an existing one (if any such exists) by GID and RID match.
If no such item exists, the server will fallback to AK-APPEND behavior and
a new item is inserted. Otherwise the merged item is returned.
commit b92a515d2be9185789f5249aebf51033848343d3
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Wed Apr 23 13:44:01 2014 +0200
CollectionSync: allow to keep the local changes.
This new property allows resources to indicate whether the CollectionSync
should overwrite the locally stored changes.
This ensures that the CollectionSync doesn't overwrite existing attributes
with the default values provided by the resource on every sync.
REVIEW: 117697
commit 39750e595081e19538242852cf7fefa25ae5fadc
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Wed Apr 23 13:41:25 2014 +0200
ResourceBase: Don't call retrieveItems with empty remoteId
This was caught in the imap resource, but we can at least fix this in
ResourceBase since a Resource should never be able to fetch items for a
collection without remoteId.
REVIEW: 117696
commit 91f4197052eb879bf1c9ef1b40e484d2babff95b
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Mon Apr 21 14:11:56 2014 +0200
ItemSync: Allow to disable the automatic delivery done feature
The imap resource relies on the item sync only finishing once deliveryDone
is called, but setTotalItems is still useful for the progress reporting,
which only the ItemSync can accurately do. This patch allows to use
setTotalItems for progress reporting, while disabling the behaviour that the
ItemSync automatically finishes once sufficient items were delivered.
REVIEW: 117673
commit fd2e9c7831d72b80825f5cb275f765d644b9d60c
Author: l10n daemon script <scripty at kde.org>
Date: Sun Apr 20 07:41:41 2014 +0000
SVN_SILENT made messages (.desktop file)
commit f079cb9e92a6f47abacc761a31c9635927b4d325
Author: l10n daemon script <scripty at kde.org>
Date: Sun Apr 20 04:37:59 2014 +0000
SVN_SILENT made messages (.desktop file)
commit f1c0c194cfa0097043fcb959c0aeb52f661b8b91
Merge: ddd30c9 b1aea8c
Author: Montel Laurent <montel at kde.org>
Date: Sat Apr 19 15:39:10 2014 +0200
Merge remote-tracking branch 'origin/KDE/4.13'
commit b1aea8c3670d9e81f1184290ea4f17e4820f5e87
Merge: f223ec9 311cdab
Author: Montel Laurent <montel at kde.org>
Date: Sat Apr 19 15:37:25 2014 +0200
Merge remote-tracking branch 'origin/KDE/4.12' into KDE/4.13
Conflicts:
CMakeLists.txt
commit 311cdabe4329e54f91ccacb6952663945b413300
Author: Montel Laurent <montel at kde.org>
Date: Sat Apr 19 15:36:02 2014 +0200
4.12.5
commit ddd30c9ee034a89c822e45ebe2a55eaab8def652
Merge: d54a1b8 f223ec9
Author: Montel Laurent <montel at kde.org>
Date: Sat Apr 19 13:09:43 2014 +0200
Merge remote-tracking branch 'origin/KDE/4.13'
commit f223ec98b6b1baeaaa256fb51c70f5f4edc874aa
Author: Montel Laurent <montel at kde.org>
Date: Sat Apr 19 13:08:22 2014 +0200
Remove duplicate code
commit d54a1b8b78bca5998ce91905b3d0faf285145b87
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Thu Apr 17 17:37:26 2014 +0200
ItemSync: Fix full sync and transaction handling
* Ensure that checkDone doesn't start the next batch while we're still fetching
the items.
This bug was triggered only if setFullSyncItems was called at least twice in streaming
mode (therefore it only appeard on large imap folders where the items
we delivered in two batches, and only during the flag sync which is a full sync).
The first call triggered the ItemFetch, but while that was in progress,
the second call went via process() to checkDone(), which cleared mProcessingBatch
and immediately started a second parallel batch, and a third batch was started
by deliveryDone(). This resulted in the first two batches (20 items), appearing as new
(because the were processed before the local items were fetched), and the already locally
available items getting deleted, because they couldn't be removed from
mUnprocessedLocalIds (since they were processed before entering that list.
We use the job counter to lock, just like everywhere else.
* mTransactionJobs should not be checked in execute(), as it is already checked in
checkDone(), and the check in execute() is only valid when using
MultiTransactionMode.
* Adapted the test to the discovered problems.
* The fetchjobs need to be part of the transaction as well, as they are otherwise
not executed before the transactoin is complete.
REVIEW: 117608
commit 775e90cd0b5ee9409472ced35d666d837b076854
Merge: bd30367 b2981ab
Author: Montel Laurent <montel at kde.org>
Date: Thu Apr 17 13:18:55 2014 +0200
Merge remote-tracking branch 'origin/KDE/4.13'
commit b2981ab08e76d0a4bbdc206f5aacf1802096767c
Author: Montel Laurent <montel at kde.org>
Date: Thu Apr 17 13:18:02 2014 +0200
Minor optimization
commit bd303678fa111e08c73e3e0b549aced9602839ea
Author: Christian Mollekopf <chrigi_1 at fastmail.fm>
Date: Thu Apr 10 11:10:27 2014 +0200
ItemSync: Use batch processing and allow throttling
With this patch we process the items in batches and gives resources the
possiblity to throttle the retrieval of messages using the
readyForNextBatch signal. This way we avoid using huge queries and
loading all items into memory, making the whole process a lot less
resource intensive, and make it work for large folder.
REVIEW: 117471
commit 6ee9f9853ccb0516344252440966135d3ea9f4a0
Merge: a4aa7a5 b437901
Author: Montel Laurent <montel at kde.org>
Date: Tue Apr 15 13:27:20 2014 +0200
Merge remote-tracking branch 'origin/KDE/4.13'
Conflicts:
akonadi/collectionrequester.h
commit b4379019d320ee49f57397351aceeea6c60ba309
Author: Montel Laurent <montel at kde.org>
Date: Tue Apr 15 13:25:33 2014 +0200
Pedantic
commit 18c16c602f1bac0767b4c7836b8ee8ff0e421f42
Author: l10n daemon script <scripty at kde.org>
Date: Mon Apr 14 07:58:55 2014 +0000
SVN_SILENT made messages (.desktop file)
commit a4aa7a59c424265f4f084f504f5292397b0df8a3
Author: l10n daemon script <scripty at kde.org>
Date: Mon Apr 14 04:58:36 2014 +0000
SVN_SILENT made messages (.desktop file)
commit 55af8f20b7b838497d829c6847fd5f7929e285c3
Merge: b880bb0 59aa632
Author: Montel Laurent <montel at kde.org>
Date: Sun Apr 13 13:37:34 2014 +0200
Merge remote-tracking branch 'origin/KDE/4.13' (conflict all the time with fix indent... I will finish to make fix in master only...)
Conflicts:
akonadi/recentcollectionaction.cpp
commit b880bb06783ad355231067f61e2f6f8913a08cd8
Merge: 8a37269 e6d15b1
Author: Montel Laurent <montel at kde.org>
Date: Sun Apr 13 13:36:55 2014 +0200
Merge remote-tracking branch 'origin/KDE/4.13'
Conflicts:
akonadi/recentcollectionaction.cpp
akonadi/recentcollectionaction_p.h
akonadi/standardactionmanager.cpp
commit 59aa63280e92d6bd2a6ddd9ac7f4e5e3813a7eb9
Author: Montel Laurent <montel at kde.org>
Date: Sun Apr 13 13:36:02 2014 +0200
Typo
commit e6d15b1a929e4d3b53e4da02263023a4a4f9256f
Author: Montel Laurent <montel at kde.org>
Date: Sun Apr 13 13:30:09 2014 +0200
Fix fill recent menu
commit 8a372690903196c97fbc2acfab78d2b063c6308e
Merge: 9e0f9fe d304427
Author: Montel Laurent <montel at kde.org>
Date: Sun Apr 13 13:16:18 2014 +0200
Merge remote-tracking branch 'origin/KDE/4.13'
Conflicts:
akonadi/recentcollectionaction.cpp
akonadi/recentcollectionaction_p.h
akonadi/standardactionmanager.cpp
commit d30442760440bbe604ab20278f7b38a754404edf
Author: Montel Laurent <montel at kde.org>
Date: Sun Apr 13 13:09:11 2014 +0200
Fix Bug 316097 - copying or moving folder to one of its own subfolders should never be possible
FIXED-IN: 4.13.1
BUG: 316097
commit 90defb6a2543abb89038e3013d5e346b52706cca
Author: Montel Laurent <montel at kde.org>
Date: Sun Apr 13 12:20:19 2014 +0200
Start to fix Bug 316097 - copying or moving folder to one of its own subfolders should never be possible
Disable move folder to its subfolder.
Disable copy folder in own folder
Still need to fix recent folder
But for me copy to subfolder must be authorized
CCBUG: 316097
commit 9e0f9fe41cd8ff1eeb47ddb347a8608147127cbc
Merge: 1caf78c 5d7c6dc
Author: Montel Laurent <montel at kde.org>
Date: Sun Apr 13 12:09:06 2014 +0200
Merge remote-tracking branch 'origin/KDE/4.13'
Conflicts:
akonadi/itemsearchjob.cpp
akonadi/standardactionmanager.cpp
commit 5d7c6dc268a265ed37ff4727d67b6c64002dd29e
Author: Montel Laurent <montel at kde.org>
Date: Sun Apr 13 12:06:31 2014 +0200
Not necessary to use variable
commit 1caf78ce27279a67a8be8cd76bb2dd8cabb6725c
Author: Montel Laurent <montel at kde.org>
Date: Sun Apr 13 11:22:14 2014 +0200
Update
commit 4f28c13064e2659ef68b4607fb026dc085f39e80
Author: Volker Krause <vkrause at kde.org>
Date: Sun Apr 13 11:18:44 2014 +0200
Deprecate more unused stuff in kpimutils.
kpimutils is a dependency nightmare for KF5, and an unrestricted dumping
ground, so everything we can remove there helps.
commit 1d7862a782f082a8839e93b1d6e4be008c17ae2d
Author: David Faure <faure at kde.org>
Date: Fri Apr 11 23:41:25 2014 +0200
ItemSearchJob: implement debug string, to see the search details.
commit 99a56a80d7e33ea74d526115902dc0c1ee1388a1
Merge: f8d94d9 87d40ff
Author: Montel Laurent <montel at kde.org>
Date: Fri Apr 11 08:45:57 2014 +0200
Merge remote-tracking branch 'origin/KDE/4.13'
commit 87d40fff187317d550810d741cc98c2afa5a87b1
Author: Montel Laurent <montel at kde.org>
Date: Fri Apr 11 08:45:20 2014 +0200
Add clear button
commit f8d94d953367583309269f40f08282e83a100ece
Author: l10n daemon script <scripty at kde.org>
Date: Thu Apr 10 05:09:06 2014 +0000
SVN_SILENT made messages (.desktop file)
commit 149975c04f09d2eb49e82487f7a1b62448a23d92
Merge: f3640ef ebc15a8
Author: Montel Laurent <montel at kde.org>
Date: Wed Apr 9 13:46:36 2014 +0200
Merge remote-tracking branch 'origin/KDE/4.13'
Conflicts:
CMakeLists.txt
akonadi/tests/testsearchplugin/akonaditestsearchplugin.desktop
commit f3640ef6dbfbdf30aff9e777aeb4efeedf68c6cf
Author: l10n daemon script <scripty at kde.org>
Date: Tue Apr 8 06:19:45 2014 +0000
SVN_SILENT made messages (.desktop file)
commit 14ffb5704e3376b874a50f5e8a631770d629ce6d
Merge: 83a0ddc a3a9b76
Author: Montel Laurent <montel at kde.org>
Date: Tue Apr 8 07:27:26 2014 +0200
Merge remote-tracking branch 'origin/KDE/4.13'
Conflicts:
CMakeLists.txt
commit 83a0ddc4a4c7f61c59ac9c55b9d85e0d040f2fcb
Merge: 1db666c 7c9bdfd
Author: Montel Laurent <montel at kde.org>
Date: Mon Apr 7 20:10:24 2014 +0200
Merge remote-tracking branch 'origin/KDE/4.13'
commit 1db666c08eaba33f94d9f876ef73afaecab104f1
Merge: 31d5373 2e4d3da
Author: Montel Laurent <montel at kde.org>
Date: Mon Apr 7 07:41:06 2014 +0200
Merge remote-tracking branch 'origin/KDE/4.13'
Conflicts:
akonadi/itemsearchjob.cpp
akonadi/searchcreatejob.cpp
More information about the commits
mailing list