7 commits - bin/kolab_smtp_access_policy.py pykolab/setup

Jeroen van Meeuwen vanmeeuwen at kolabsys.com
Fri Feb 28 13:49:22 CET 2014


 bin/kolab_smtp_access_policy.py  |    2 +-
 pykolab/setup/setup_ldap.py      |    2 ++
 pykolab/setup/setup_mta.py       |    5 ++++-
 pykolab/setup/setup_mysql.py     |    5 ++++-
 pykolab/setup/setup_roundcube.py |    2 +-
 5 files changed, 12 insertions(+), 4 deletions(-)

New commits:
commit 9a16e303517e4b2612dec03be02355887070b8e2
Author: Jeroen van Meeuwen (Kolab Systems) <vanmeeuwen at kolabsys.com>
Date:   Fri Feb 28 13:39:21 2014 +0100

    Different paths to a mysql sock or pid (#2879)

diff --git a/pykolab/setup/setup_mysql.py b/pykolab/setup/setup_mysql.py
index e9783c7..36a0bec 100644
--- a/pykolab/setup/setup_mysql.py
+++ b/pykolab/setup/setup_mysql.py
@@ -64,7 +64,10 @@ def execute(*args, **kw):
         }
 
     answer = 0
-    if os.path.exists('/var/run/mysqld/mysqld.sock') or os.path.exists('/var/run/mysql/mysql.sock'):
+    if os.path.exists('/var/lib/mysql/mysql.sock') or \         # Regular old-fashioned Enterprise Linux
+            os.path.exists('/var/run/mysqld/mysqld.sock') or \  # Debian
+            os.path.exists('/var/run/mysql/mysql.sock') or \    # (open)SUSE
+            os.path.exists('/var/run/mysqld/mysqld.pid'):       # "Unbreakable" Linux from Oracle
         answer = utils.ask_menu(_("What MySQL server are we setting up?"), options)
 
     if answer == "1" or answer == 1:


commit e77da88bb8aa7c0e8564fb0bf43cd8d1fed7fded
Author: Jeroen van Meeuwen (Kolab Systems) <vanmeeuwen at kolabsys.com>
Date:   Fri Feb 28 13:15:03 2014 +0100

    Allow directories and files sought to be found in levels deeper than
    just /use/share/doc/ (#2871)

diff --git a/pykolab/setup/setup_roundcube.py b/pykolab/setup/setup_roundcube.py
index e375f9b..4e14ee2 100644
--- a/pykolab/setup/setup_roundcube.py
+++ b/pykolab/setup/setup_roundcube.py
@@ -139,7 +139,7 @@ def execute(*args, **kw):
     for root, directories, filenames in os.walk('/usr/share/doc/'):
         for directory in directories:
             if directory.startswith("roundcubemail"):
-                for root, directories, filenames in os.walk(os.path.join('/usr/share/doc/', directory)):
+                for root, directories, filenames in os.walk(os.path.join(root, directory)):
                     for filename in filenames:
                         if filename.startswith('mysql.initial') and filename.endswith('.sql'):
                             schema_filepath = os.path.join(root,filename)


commit 1284357760d54029d36bb650e8c7837763e8f1d9
Author: Aeneas Jaißle <aj at ajaissle.de>
Date:   Fri Feb 28 13:10:00 2014 +0100

    With the attached patch, we (openSUSE) are able to identiify a running
    MySQL server. Without, only /var/run/mysqld/mysqld.sock is checked, but
    we use /var/run/mysql/mysql.sock (without a trailing 'd').

diff --git a/pykolab/setup/setup_mysql.py b/pykolab/setup/setup_mysql.py
index 4b2e8c2..e9783c7 100644
--- a/pykolab/setup/setup_mysql.py
+++ b/pykolab/setup/setup_mysql.py
@@ -64,7 +64,7 @@ def execute(*args, **kw):
         }
 
     answer = 0
-    if os.path.exists('/var/run/mysqld/mysqld.sock'):
+    if os.path.exists('/var/run/mysqld/mysqld.sock') or os.path.exists('/var/run/mysql/mysql.sock'):
         answer = utils.ask_menu(_("What MySQL server are we setting up?"), options)
 
     if answer == "1" or answer == 1:


commit 5c3413f59c49cbc734fddd2ed25bc25a1beee850
Author: Aeneas Jaißle <aj at ajaissle.de>
Date:   Fri Feb 28 13:05:07 2014 +0100

    setup_ldap knows about
    * /usr/sbin/setup-ds-admin.pl
    * /usr/sbin/setup-ds
    
    but it does not know about setup-ds.pl, that comes with upstream
    389-ds-base.

diff --git a/pykolab/setup/setup_ldap.py b/pykolab/setup/setup_ldap.py
index 66c5d41..e974c69 100644
--- a/pykolab/setup/setup_ldap.py
+++ b/pykolab/setup/setup_ldap.py
@@ -317,6 +317,8 @@ ServerAdminPwd = %(admin_pass)s
         setup_ds_admin = "/usr/sbin/setup-ds-admin.pl"
     #elif os.path.isfile("/usr/sbin/setup-ds-admin"):
         #setup_ds_admin = "/usr/sbin/setup-ds-admin"
+    elif os.path.isfile("/usr/sbin/setup-ds.pl"):
+        setup_ds_admin = "/usr/sbin/setup-ds.pl"
     elif os.path.isfile("/usr/sbin/setup-ds"):
         setup_ds_admin = "/usr/sbin/setup-ds"
     else:


commit 5601fb5e5e6b25c4f73bcd01893255c41d3414fe
Author: Jeroen van Meeuwen (Kolab Systems) <vanmeeuwen at kolabsys.com>
Date:   Fri Feb 28 13:00:00 2014 +0100

    Fix indentation (#2872), fixing writing out amavisd (#2864)
    Correct error message (#2868)

diff --git a/pykolab/setup/setup_mta.py b/pykolab/setup/setup_mta.py
index 64b3317..3b064c6 100644
--- a/pykolab/setup/setup_mta.py
+++ b/pykolab/setup/setup_mta.py
@@ -383,15 +383,18 @@ result_format = shared+%%s
 
             t = Template(template_definition, searchList=[amavisd_settings])
 
+        fp = None
         if os.path.isdir('/etc/amavisd'):
             fp = open('/etc/amavisd/amavisd.conf', 'w')
         elif os.path.isdir('/etc/amavis'):
             fp = open('/etc/amavis/amavisd.conf', 'w')
+
+        if not fp == None:
             fp.write(t.__str__())
             fp.close()
 
         else:
-            log.error(_("Could not write out Amavis configuration file /etc/amavisd/amavisd.conf"))
+            log.error(_("Could not write out Amavis configuration file amavisd.conf"))
             return
 
     # On APT installations, /etc/amavis/conf.d/ is a directory with many more files.


commit 7bd801bd4493f46994099a833958640104ebc0ed
Merge: d6bdaca c1153b7
Author: Jeroen van Meeuwen (Kolab Systems) <vanmeeuwen at kolabsys.com>
Date:   Thu Feb 27 16:17:01 2014 +0100

    Merge branch 'master' of ssh://git.kolabsys.com/git/pykolab



commit d6bdaca746e6fd24dc46e36103c8744a4b1a7bce
Author: Jeroen van Meeuwen (Kolab Systems) <vanmeeuwen at kolabsys.com>
Date:   Sun Feb 16 13:05:27 2014 +0100

    Fix typo

diff --git a/bin/kolab_smtp_access_policy.py b/bin/kolab_smtp_access_policy.py
index 935fc6e..0d3fa2f 100755
--- a/bin/kolab_smtp_access_policy.py
+++ b/bin/kolab_smtp_access_policy.py
@@ -1375,7 +1375,7 @@ def permit(message, policy_request=None):
     # If the sender is using an alias as the envelope sender address, take
     # into account the preferred domain policy for appending the Sender
     # and/or X-Sender headers.
-    elif policy_requiest.sasl_user_uses_alias:
+    elif policy_request.sasl_user_uses_alias:
         # Domain-specific setting?
         if not policy_request.sender_domain == None:
             alias_sender_header = conf.get(policy_request.sender_domain, 'alias_sender_header')




More information about the commits mailing list