2 commits - src/xcardconversions.h tests/bindingstest.cpp

Christian Mollekopf mollekopf at kolabsys.com
Thu Sep 19 10:47:24 CEST 2013


 src/xcardconversions.h |    2 --
 tests/bindingstest.cpp |    2 ++
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit dccb00af60856a9157dd1e0b2a27533f965a3d62
Author: Christian Mollekopf <mollekopf at kolabsys.com>
Date:   Thu Sep 19 10:47:12 2013 +0200

    Removed that warning when reading empty distlists.

diff --git a/src/xcardconversions.h b/src/xcardconversions.h
index 4919382..4efca8f 100644
--- a/src/xcardconversions.h
+++ b/src/xcardconversions.h
@@ -1131,8 +1131,6 @@ boost::shared_ptr<Kolab::DistList> readCard <Kolab::DistList> (const vcard_4_0::
             members.push_back(Shared::toContactReference(m.uri()));
         }
         distlist->setMembers(members);
-    } else {
-        WARNING("empty distlist");
     }
     return distlist;
 }


commit deed4f8794e4efde235731d4327da7db55c83578
Author: Christian Mollekopf <mollekopf at kolabsys.com>
Date:   Wed Sep 18 21:28:51 2013 +0200

    verify that the benchmarks actually do something useful.

diff --git a/tests/bindingstest.cpp b/tests/bindingstest.cpp
index c0a63c0..2e77be5 100644
--- a/tests/bindingstest.cpp
+++ b/tests/bindingstest.cpp
@@ -770,6 +770,7 @@ void BindingsTest::errorRecoveryTest()
 void BindingsTest::BenchmarkRoundtripKolab()
 {
     const Kolab::Event &event = Kolab::readEvent(TEST_DATA_PATH "/testfiles/icalEvent.xml", true);
+    QVERIFY(!Kolab::errorOccurred());
     std::string result = Kolab::writeEvent(event);
     QBENCHMARK {
         Kolab::readEvent(result, false);
@@ -779,6 +780,7 @@ void BindingsTest::BenchmarkRoundtripKolab()
 void BindingsTest::BenchmarkRoundtrip()
 {
     const Kolab::Event &event = Kolab::readEvent(TEST_DATA_PATH "/testfiles/icalEvent.xml", true);
+    QVERIFY(!Kolab::errorOccurred());
     std::string result;
     QBENCHMARK {
         result = Kolab::writeEvent(event);




More information about the commits mailing list