lib/kolab_client_task.php public_html/js

Aleksander Machniak machniak at kolabsys.com
Fri Jan 4 14:46:34 CET 2013


 lib/kolab_client_task.php     |    3 +++
 public_html/js/kolab_admin.js |   16 +++-------------
 2 files changed, 6 insertions(+), 13 deletions(-)

New commits:
commit 09365af3e7e653d98b8ab9780a82dd1351e1c91b
Author: Aleksander Machniak <alec at alec.pl>
Date:   Fri Jan 4 14:43:38 2013 +0100

    Implement autocompletion minimum length limit (add 'autocomplete_min_length' option) (Bug #1486)
    Increase autocompletion request delay - the time from key press to the request (Bug #1486)

diff --git a/lib/kolab_client_task.php b/lib/kolab_client_task.php
index 5fe2473..8583e01 100644
--- a/lib/kolab_client_task.php
+++ b/lib/kolab_client_task.php
@@ -1315,9 +1315,12 @@ class kolab_client_task
             ));
         }
 
+        $ac_min_len = $this->config_get('autocomplete_min_length', 1, Conf::INT);
+
         $this->output->set_env('form_id', $attribs['id']);
         $this->output->set_env('assoc_fields', $assoc_fields);
         $this->output->set_env('required_fields', $req_fields);
+        $this->output->set_env('autocomplete_min_length', $ac_min_len);
         $this->output->add_translation('form.required.empty', 'form.maxcount.exceeded',
             $name . '.add.success', $name . '.edit.success', $name . '.delete.success',
             'add', 'edit', 'delete');
diff --git a/public_html/js/kolab_admin.js b/public_html/js/kolab_admin.js
index 3290bf1..959f0f1 100644
--- a/public_html/js/kolab_admin.js
+++ b/public_html/js/kolab_admin.js
@@ -514,11 +514,11 @@ function kolab_admin()
       case 37:  // left
       case 39:  // right
         if (!e.shiftKey)
-	      return;
+          return;
     }
 
     // start timer
-    this.ac_timer = window.setTimeout(function() { kadm.ac_start(props); }, 200);
+    this.ac_timer = window.setTimeout(function() { kadm.ac_start(props); }, 500);
     this.ac_input = e.target;
 
     return true;
@@ -565,10 +565,7 @@ function kolab_admin()
     this.ac_stop();
 
     if (q.length && q.length < min) {
-      if (!this.ac_info) {
-        this.ac_info = this.display_message(
-          this.t('search.acchars').replace('$min', min));
-      }
+      this.display_message(this.t('search.acchars').replace('$min', min), 'notice', 2000);
       return;
     }
 
@@ -698,15 +695,8 @@ function kolab_admin()
     if (this.ac_data)
       this.ac_data.abort();
 
-    if (this.ac_info)
-      this.hide_message(this.ac_info);
-
-    if (this.ac_msg)
-      this.hide_message(this.ac_msg);
-
     this.ac_data = null;
     this.ac_info = null;
-    this.ac_msg = null;
   };
 
 





More information about the commits mailing list