gunnar: server/kolab-webadmin/kolab-webadmin/test/KolabAdmin/Unit BaseTest.php, 1.6, 1.7

cvs at kolab.org cvs at kolab.org
Sun Feb 21 11:04:51 CET 2010


Author: gunnar

Update of /kolabrepository/server/kolab-webadmin/kolab-webadmin/test/KolabAdmin/Unit
In directory doto:/tmp/cvs-serv5627/kolab-webadmin/kolab-webadmin/test/KolabAdmin/Unit

Modified Files:
	BaseTest.php 
Log Message:
kolab/issue3499 (Kolab web admin does not use LDAP escaping)

Found the actual issue I tried to fix last time which was the broken midair collision check. Now it also makes sense why the function broke with the later fixing I did. Basically countMail() was not aware of any LDAP escaping when counting objects with an excluded DN. Should now be fixed and I added a test for that problem.

Index: BaseTest.php
===================================================================
RCS file: /kolabrepository/server/kolab-webadmin/kolab-webadmin/test/KolabAdmin/Unit/BaseTest.php,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -d -r1.6 -r1.7
--- BaseTest.php	21 Feb 2010 09:23:02 -0000	1.6
+++ BaseTest.php	21 Feb 2010 10:04:49 -0000	1.7
@@ -88,6 +88,19 @@
         );
     }
 
+    public function testCountmailReturnsZeroOnExistingMailWithEscapedDnCharactersIfDnExcluded()
+    {
+        $this->_add($this->_getTestUser(',=,'));
+        $this->assertEquals(
+            0,
+            $this->ldap->countMail(
+                $_SESSION['base_dn'],
+                'kolabadmin.test.,=,@' . $_SESSION['fqdnhostname'],
+                'cn=' . $this->ldap->dn_escape('KolabAdmin TestUser,=,') . ',' . $_SESSION['base_dn']
+            )
+        );
+    }
+
     public function testAddingObjectIsSuccessful()
     {
         $this->_add($this->_getTestUser());





More information about the commits mailing list