mathieu: utils/ci/toolbox kolab-test-toolbox.pl,1.2,1.3

cvs at kolab.org cvs at kolab.org
Thu Dec 10 19:42:28 CET 2009


Author: mathieu

Update of /kolabrepository/utils/ci/toolbox
In directory doto:/tmp/cvs-serv16648

Modified Files:
	kolab-test-toolbox.pl 
Log Message:
don't print usage when fatal error. Also avoid unitialized $command

Index: kolab-test-toolbox.pl
===================================================================
RCS file: /kolabrepository/utils/ci/toolbox/kolab-test-toolbox.pl,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -d -r1.2 -r1.3
--- kolab-test-toolbox.pl	10 Dec 2009 18:27:16 -0000	1.2
+++ kolab-test-toolbox.pl	10 Dec 2009 18:42:26 -0000	1.3
@@ -157,11 +157,11 @@
 sub remote_command
 {
     my $domip = shift;
-    my $command = shift || undef;
+    my $command = shift || '';
     my $no_die_on_error = shift || 0;
     
     my $ret;
-    if(defined($command)) {
+    if($command ne '') {
         $ret = system('ssh',
             '-i', conf('storage_pool_dir').'/key',
             '-o', 'StrictHostKeyChecking=no',
@@ -969,7 +969,7 @@
     'man' => \$o_man,
     'platform=s' => \$platform,
     '<>' => \&process,
-    ) or pod2usage(2);
+    );
 
 pod2usage(-exitstatus => 0, -verbose => 2) if $o_man;
 pod2usage(-exitstatus => 0, -verbose => 1) if $o_help;





More information about the commits mailing list